monit icon indicating copy to clipboard operation
monit copied to clipboard

Bugfix for Ubuntu & reload over restart for faster config updates

Open bitgangsta opened this issue 11 years ago • 2 comments

Hi,

Two changes are in this pull. We had made this fork a while ago, so I'm happy to update / rebase if need be. However, I wanted to see if this would be friendly before I do.

a) We updated the config updates to cause a reload rather than restart, for performance reasons. This should be fine, and I would think is preferable, but let me know if you disagree.

b) Ubuntu's default shell isn't bash (see discussion on that commit). The best practice should be to use /usr/bin/env to find the bash location.

Any concerns/ comments?

bitgangsta avatar Dec 18 '13 01:12 bitgangsta

It was probably /bin/sh out of habit and that /bin/sh is the system (posix compliant) shell...

Have you tested this out? Glancing at recipes/default.rb I wonder how monit would handle "reload" vs "start" on a node's firstboot?

In principal I think a version of this with reduced scope could be interested (reload vs restart on template render / config change)

yourabi avatar Sep 10 '14 04:09 yourabi

Would it be possible to just have reload included as in https://github.com/apsoto/monit/pull/48/files#diff-55bf87238c9b8af164c5133a60721f12R15? That would probably be helpful by itself.

daanemanz avatar Jan 22 '15 19:01 daanemanz