sdk-generator icon indicating copy to clipboard operation
sdk-generator copied to clipboard

Async Support in Python SDK

Open ms7m opened this issue 2 years ago • 9 comments

More information @ #452

ms7m avatar May 24 '22 13:05 ms7m

Hey @ms7m, just wanted to let you know that our engineer who is going to review this on leave and is back next week 😉

Awesome work 👏🏻

TorstenDittmann avatar Jun 01 '22 14:06 TorstenDittmann

Nice work so far! Just a few comments

Thanks, I've been swamped at work and battling a cold -- but I'll get these changes sorted!

ms7m avatar Jun 15 '22 00:06 ms7m

@ms7m, sorry, but would you please fix the merge conflict?

stnguyen90 avatar Oct 14 '22 16:10 stnguyen90

@stnguyen90 sure, my branch is quite behind since this kinda fell off my radar.

ms7m avatar Oct 15 '22 05:10 ms7m

@abnegate is this relevant?

lohanidamodar avatar Jan 29 '23 06:01 lohanidamodar

@ms7m seems like the tests are still failing. Any ideas why?

stnguyen90 avatar Feb 07 '23 05:02 stnguyen90

@stnguyen90 -- running locally, only a single test is failing. I'll take a crack at this weekend and get this freed up!

ms7m avatar Feb 08 '23 18:02 ms7m

@ms7m Is it possible to have the async methods without adding the AsyncClient? So the async versions of the methods would be together with the sync versions in the existing client?

abnegate avatar Feb 14 '23 09:02 abnegate