sdk-generator icon indicating copy to clipboard operation
sdk-generator copied to clipboard

Published 20 hours ago • verified publisher icon appwrite

Adding Scoop support

Open CEbbinghaus opened this issue 3 years ago • 5 comments
trafficstars

This PR is to add scoop support to the CLI install. With first a github hosted uri to install it manually:

> scoop install https://raw.githubusercontent.com/appwrite/sdk-for-cli/master/appwrite.json

and hopefully the ability for scoop to verify hashes as well as install it via the main bucket

> scoop install appwrite

which will require a working autoupdater and working version check

This PR implements Feature appwrite/sdk-for-cli/issues/39

CEbbinghaus avatar May 22 '22 09:05 CEbbinghaus

Install can be tested with this command:

$ scoop install https://gist.githubusercontent.com/CEbbinghaus/3219a010325e9684839f7ce5ecea4afd/raw/2f19d33dc4581658d5e73edda4d763644129621a/appwrite.json

Generated with the SDK

CEbbinghaus avatar May 23 '22 13:05 CEbbinghaus

The build task seems to be failing because of Docker rate limits not the changes I added

CEbbinghaus avatar Jun 13 '22 06:06 CEbbinghaus

The build task seems to be failing because of Docker rate limits not the changes I added

Restarted failed jobs. All green now 💚

Meldiron avatar Jun 15 '22 07:06 Meldiron

Sweet. This PR is ready to merge then as it shouldn't contain any extra changes. It's going to be the prerequisite for the other changes so i am very keen to get it merged asap

CEbbinghaus avatar Jun 16 '22 01:06 CEbbinghaus

Requesting another review as its still not merged and the merging is blocked. It might be smart to leave it until ScoopInstaller/Scoop#3146 is merged as it would allow for the ARM release to be installed too

CEbbinghaus avatar Sep 26 '22 07:09 CEbbinghaus

@Meldiron looks like the blocking issue was merged can you help move forward with this?

lohanidamodar avatar Jan 29 '23 06:01 lohanidamodar

Thanks @lohanidamodar, since opening this PR I have learned a lot about scoop & how it works. There are some small modifications I want to do to it as it stands right now since it would require a PullRequest to the scroop repository for every version which is not desired. Instead if we can generate the Appwrite.json file a little differently, it should auto update within the scoop repository. That means that the changes will be lagging behind until scoop's main bucket does another update cycle but that is probably faster than waiting for a human review of every version.

CEbbinghaus avatar Jan 30 '23 02:01 CEbbinghaus

@CEbbinghaus thank you for your immediate response. Please make the necessary changes and request another review.

lohanidamodar avatar Jan 30 '23 05:01 lohanidamodar

@lohanidamodar who should I request the review from?

CEbbinghaus avatar Jan 30 '23 06:01 CEbbinghaus

So this is ready to merge? The failed Travis build seems to be more of an amnesty rather than due to my changes. Is anything hold it up?

CEbbinghaus avatar Feb 27 '23 06:02 CEbbinghaus

Updated with the latest from master. Lets hope it fixes the CI task :3

Edit: Seems that is the case. Should be good to merge.

CEbbinghaus avatar Mar 02 '23 03:03 CEbbinghaus

How do we trigger a run for the CLI SDK so it updates the content & generates the files. Once that is complete I can create the PR to merge appwrite into the main scoop bucket which I can add back into the docs so you merely run scoop install appwrite

CEbbinghaus avatar Jun 08 '23 12:06 CEbbinghaus