demo-todo-with-angular icon indicating copy to clipboard operation
demo-todo-with-angular copied to clipboard

Published 20 hours ago • verified publisher icon appwrite

refactor: use injectable service and providers

Open santoshyadavdev opened this issue 3 years ago • 7 comments

The PR uses Angular way of using AppWriteService, this goes more in a way Angular Standard to inject the service.

The APP_INITIALIZER will be responsible for initializing the AppWrite service so instance is available before it is being used

santoshyadavdev avatar May 04 '22 18:05 santoshyadavdev

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
todo-with-angular ✅ Ready (Inspect) Visit Preview May 4, 2022 at 7:12PM (UTC)

vercel[bot] avatar May 04 '22 18:05 vercel[bot]

Can someone check the API is giving some error or did i made some mistake Cc: @brandonroberts

santoshyadavdev avatar May 04 '22 19:05 santoshyadavdev

@santoshyadavdev if you're using the PR preview, you will most likely get a CORS error because the subdomain isn't added to the platforms for this project. What's the error?

brandonroberts avatar May 04 '22 20:05 brandonroberts

@santoshyadavdev if you're using the PR preview, you will most likely get a CORS error because the subdomain isn't added to the platforms for this project. What's the error?

Yes it is CORS error.

santoshyadavdev avatar May 04 '22 20:05 santoshyadavdev

@brandonroberts, once 0.14 is out, we should probably use the new wildcard hostname for these demo apps.

eldadfux avatar May 04 '22 21:05 eldadfux

Yep, I was thinking the same thing

brandonroberts avatar May 04 '22 21:05 brandonroberts

@santoshyadavdev if everything works locally, we should be ok to review it when you are ready. I'll pull the changes down locally also

brandonroberts avatar May 05 '22 13:05 brandonroberts