console icon indicating copy to clipboard operation
console copied to clipboard

FIX: Inconsistency in User Verification Status between Email and Phone Number & Password Field Not Reset On Email Update

Open joyalgeorgekj opened this issue 7 months ago • 4 comments

What does this PR do?

  • There was a verification status mismatch in the alert/popup when user auth verifying phone number in Appwrite console. The issue has been reported to appwrite/console Repo #1392
  • Also addressing this Issue too Password Field Not Reset On Email Update Issue #976

Changes:

  • Issue Inconsistency in User Verification Status between Email and Phone Number #1392:

    • Alert Status mismatch corrected. Added ! to user verification check condition $user.phoneVerification ? 'unverified' : 'verified' changed to !$user.phoneVerification ? 'unverified' : 'verified'.
    • Formatting the name if we are verifying email and has name for user.
    • Formatting the name and email if we are verifying phone number and has name and email for user.
    • Removed The Account from both phone and email verification because the condition is not valid. Condition says that if account has no username, email and phone user use The account instead of using name, email or phone. Which means its an anonymous account that doesn't need verification.
    • Rule followed for the Formatting:
      • XYZ's email has been verified.
      • XYZ's email has been unverified.
      • XYZ's phone has been verified.
      • XYZ's phone has been unverified.
  • Issue Password Field Not Reset On Email Update #976:

    • Just set the emailPassword to null after email updated successfully.

Test Plan

  • Checked if the formatting working properly.
  • Email Verification Checks
    • Tested name with and without ending with s.
  • Phone Verification Checks
    • Tested email and name ending with s and without s.
    • Status alert checked and made sure it was showing right verification status.,

Related PRs and Issues

Addressing Issue #976 : There was this PR https://github.com/appwrite/console/pull/1136 but it had conflicts and wasn't resolved till now (1 month has been passed)

  • [X] There was a PR but it didn't follow the Rules and didn't merge, Hence This PR!

Have you read the Contributing Guidelines on issues?

  • [X] I have read and followed the Guidelines showing above.

joyalgeorgekj avatar Jul 13 '25 09:07 joyalgeorgekj

@stnguyen90 @ItzNotABug PR review request!

joyalgeorgekj avatar Jul 13 '25 12:07 joyalgeorgekj

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-07-14 17:17:18 CET

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-07-14 17:17:17 CET

@ItzNotABug and @DH-555: The changes has been made.

  • Created a condition check for the presence of user name and email.
  • Removed Unwanted space in the notification.

Requesting review.

joyalgeorgekj avatar Jul 14 '25 17:07 joyalgeorgekj