console icon indicating copy to clipboard operation
console copied to clipboard

🚀 Feature: more accurate email validation at sign in and sign up

Open donni106 opened this issue 2 years ago • 7 comments

🔖 Feature description

The sign in and sign up forms validate the email address:

image

When passing without the ending, i.e. ".com", the validation is missing and the form is sent to the server, which then validates:

image

The email input could already validate against the full accurate email format.

🎤 Pitch

As the email format will be validates after sending the form anyways and there exists a form input validation in the frontend, it could be extended with the full email format validation including ".com" endings.

👀 Have you spent some time to check if this issue has been raised before?

  • [X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

donni106 avatar Jan 06 '23 14:01 donni106

@TorstenDittmann, do we want to update the client-side validation for this? According to MDN, something@something is valid:

A single properly-formed email address. This doesn't necessarily mean the email address exists, but it is at least formatted correctly. In simple terms, this means username@domain or [email protected].

stnguyen90 avatar Jan 06 '23 23:01 stnguyen90

Hi, I can work on this issue.

shishir-prasad avatar Jan 08 '23 02:01 shishir-prasad

I would like to work on this. @stnguyen90

AkashSharma001 avatar Jan 09 '23 15:01 AkashSharma001

@TorstenDittmann, do we want to update the client-side validation for this? According to MDN, something@something is valid:

A single properly-formed email address. This doesn't necessarily mean the email address exists, but it is at least formatted correctly. In simple terms, this means username@domain or [email protected].

IMO, formatting email client side can lead to errors. There are so many possible ways to write an email, that even this regex doesn't 100% work. There are other issues too.

TGlide avatar Jan 10 '23 10:01 TGlide

Anyways I suggest having the same validations in the client and on the server?!

donni106 avatar Jan 10 '23 14:01 donni106

It looks like you are sign in for the first time. Follow this step

  1. click to sign-in now
  2. accept the certificate and now try to sign up I hope this will help.

Nandini99-git avatar Jan 29 '23 08:01 Nandini99-git

@TorstenDittmann, do we want to update the client-side validation for this? According to MDN, something@something is valid:

A single properly-formed email address. This doesn't necessarily mean the email address exists, but it is at least formatted correctly. In simple terms, this means username@domain or [email protected].

Yeah, let's allow these e-mails. Especially in Windows domain and co its quite common to have these type of e-mails.

TorstenDittmann avatar Feb 28 '23 07:02 TorstenDittmann