apptentive-react-native icon indicating copy to clipboard operation
apptentive-react-native copied to clipboard

appID vs appleID

Open TomSwift opened this issue 5 years ago • 3 comments

Looking for clarity on whether this is a purposeful naming mismatch or not, and whether there is documentation on either:

https://github.com/apptentive/apptentive-react-native/blob/21bcdb8450f53ccdea465bf1e12ccfb30919b214/ios/RNApptentiveModule.m#L53

I don't see any documentation in the React Native Integration Reference, and only a single reference to appID in a code sample in the iOS Integration Reference. Is setting this property required?

TomSwift avatar Apr 24 '19 20:04 TomSwift

Thanks for bringing this to our attention. I've opened an issue internally around improving the documentation here.

But to answer your question, this value should be set to the iTunes Store ID of the app. If the app hasn't yet been released, you can provisionally create it in Apple's App Store Connect site and grab the value from the "Apple ID" field on the "App Information" tab for the app.

It is used for the (currently not exposed in our React Native module) openAppStore method which launches the App Store and navigates to the specified app, and by the rating prompt on devices running iOS 10.2.x or earlier (which don't support the OS's built-in rating dialog).

On the iOS side of things, it's named appID mostly for historical reasons, so appleID is an attempt to move toward consistency with Apple's own nomenclature.

frankus avatar Apr 24 '19 20:04 frankus

Thanks. It's unfortunate naming on Apple's part, since "Apple ID" refers to a couple of entirely different things. I've seen other vendors who want this value call it appleAppID.

TomSwift avatar Apr 24 '19 20:04 TomSwift

I ran into this again today (3 years later, updating our Apptentive integration...). It's annoying that this property isn't expressed in the react-native SDK because it results in a runtime warning to the console:

E/Apptentive: [Apptentive Main Queue] No App ID set. This may keep the ratings prompt from directing users to your app in the App Store.

TomSwift avatar Jan 12 '22 19:01 TomSwift