apptentive-android
apptentive-android copied to clipboard
Message Center: Button text not visible
Hi, We are using Message Center feature in our app. We came to notice that the button text color is not visible properly and also not customizable from theme override.
We are using material design theme in our app.
Apptentive library version: 5.4.5
Hey @faizfolio,
We're working on migrating our UI to material design components. In a mean time you can fix button style with this snippet (inside your theme file):
<style name="ApptentiveButtonStyle" parent="Apptentive.Widget.Button.Borderless">
<item name="android:textColor">@color/colorPrimary</item>
</style>
<style name="ApptentiveThemeOverride">
...
<item name="apptentiveInteractionButtonStyle">@style/ApptentiveButtonStyle</item>
</style>
This still remains same. when we can expect new library?
Hi @harisf3 ! Let me sync with my team to get you an answer.
Stay tuned,
Casey
Hi @harisf3,
Thanks again for this new report. Did the override that @weeeBox provided previously fix the other button style issue for you? Let me know as we're working to prioritize material design changes more broadly.
Also, could you email me directly at [email protected] and let me know which specific app you're working on? I'd like to keep your Customer Success Manager in the loop as we work on a solution.
Thanks!
Casey
Yup the previous override kinda fixed the issue, it showed black test over blue background, which is not ideal but better than invisible at all.
Having the same problem as what @harisf3 reported on October 3rd. Any updates here? I'm on v5.5.0, androidx 1.0.0, targeting 28 building on Android 10. The theme override style is not working.
Hi @samtipton, sorry that you're seeing the same issue. I'll work with my Android engineers to get you a more complete answer.
Apologies if this takes longer than usual over the holidays.
Feel free to reach us at [email protected] if you have any further questions, otherwise I'll follow up here when I know more.
Any update on this issue @CaseyApptentive? I'm following up on old tickets in our project.
@CaseyApptentive please take a look at a related issue with hardcoded values for the buttons in the dialog here:
https://github.com/apptentive/apptentive-android/issues/202
In general it's bad practice to hardcode button heights, specially when they are not compliant with Google Accessibility minimum requirements of 48 dp https://support.google.com/accessibility/android/answer/7101858?hl=en
Hi everyone. Apologies for the delay. We're working on migrating to material design components for future releases, including some other large improvements, for a forthcoming SDK. I've shared this issue with my product team.
Is this blocking a release? Let me know as it will help prioritize this on our roadmap.