singularity icon indicating copy to clipboard operation
singularity copied to clipboard

Cleanup CLI package

Open sashayakovtseva opened this issue 5 years ago • 5 comments

  1. Introduce common errors for each CLI call

sashayakovtseva avatar Aug 06 '19 13:08 sashayakovtseva

  1. Move init to the top of the file :)
  2. Overall, return nil errors only in case of successful execution.
  3. Call os.Exit, log.Fatal only in main or somewhere near it.

pisarukv avatar Aug 06 '19 14:08 pisarukv

@sashayakovtseva @cali4888

I think these are good things to do in general, not just in the cli package.

Something to consider while you do this work: Is it possible to introduce lint rules or create lint rules with our linter to make sure we avoid some of these issues in the future?

jscook2345 avatar Aug 06 '19 14:08 jscook2345

Hello,

This is a templated response that is being sent out to all open issues. We are working hard on 'rebuilding' the Singularity community, and a major task on the agenda is finding out what issues are still outstanding.

Please consider the following:

  1. Is this issue a duplicate, or has it been fixed/implemented since being added?
  2. Is the issue still relevant to the current state of Singularity's functionality?
  3. Would you like to continue discussing this issue or feature request?

Thanks, Carter

carterpeel avatar May 15 '21 16:05 carterpeel

This issue has been automatically marked as stale because it has not had activity in over 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 14 '21 22:07 stale[bot]

@sashayakovtseva Still getting this problem ? Have this been solved already ? If yes, what work around have you followed and applied ?

We're looking into the issue carefully, soon will bring to community and discuss ways to better solve as well address this. Thankyou for keeping the interest in the subject.

pedroalvesbatista avatar Jul 16 '21 01:07 pedroalvesbatista

Moved to the new Apptainer repo issue https://github.com/apptainer/apptainer/issues/1157

kmuriki avatar Mar 06 '23 03:03 kmuriki