openid_client icon indicating copy to clipboard operation
openid_client copied to clipboard

Fix a bug where only the first supported scope is included in the authentication request

Open insertjokehere opened this issue 2 years ago • 1 comments

The logic in the constructor for Flow checks if the requested scope is supported, but the break statement means it will stop processing after the first match. This means the library will only include the first matching scope in the request, rather than all scopes specified as intended.

insertjokehere avatar Jul 27 '22 03:07 insertjokehere

Just ran into this myself! Thanks for making the PR!

vanceism7 avatar Sep 23 '22 17:09 vanceism7

@insertjokehere Thanks for this PR. It has now been merged.

rbellens avatar Dec 29 '22 12:12 rbellens