design-system icon indicating copy to clipboard operation
design-system copied to clipboard

chore: [poc] enable focus rings

Open tanvibhakta opened this issue 2 years ago • 4 comments

Description

This PR exists so that design can experiment with the limitations of our existing focus ring implementation and improve upon it for the spacing and typography project.

Depends on # (pr)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration. Delete anything that is not important

  • Manual on storybook
  • Manual on main repo
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes

QA activity:

  • [ ] Test plan has been approved by relevant developers
  • [ ] Test plan has been peer reviewed by QA
  • [ ] Cypress test cases have been added and approved by either SDET or manual QA
  • [ ] Organized project review call with relevant stakeholders after Round 1/2 of QA
  • [ ] Added Test Plan Approved label after reveiwing all Cypress test

tanvibhakta avatar Sep 06 '23 04:09 tanvibhakta

⚠️ No Changeset found

Latest commit: eba9e38ee191ad4539ca5579c3a4319df2eb37cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 06 '23 04:09 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2023 4:39am

vercel[bot] avatar Sep 06 '23 04:09 vercel[bot]

/generate-alpha

tanvibhakta avatar Sep 06 '23 04:09 tanvibhakta

Publish Result: @appsmithorg/[email protected]

github-actions[bot] avatar Sep 06 '23 04:09 github-actions[bot]