appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

feat: allow HTTP port customization in Helm chart

Open damienleger opened this issue 4 months ago • 4 comments

Description

See https://github.com/appsmithorg/appsmith/issues/36761

I've been tested this with ee Helm chart. Imho tcp/8080 should be the default port but to avoid breaking change, tcp/80 remains the default port if the new variable is not specified.

Fixes #36761

Automation

/ok-to-test tags=""

:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [X] No

Summary by CodeRabbit

  • New Features

    • Enhanced configurability of the HTTP container port through the introduction of a new variable.
    • Added an optional environment variable for the container port.
  • Bug Fixes

    • Improved indentation and formatting for better readability.
  • Documentation

    • Commented-out configuration for HTTPContainerPort included for future reference.

damienleger avatar Oct 08 '24 13:10 damienleger