fix: Video2 spec flaky fix
Description
RCA: We are using youtube url for Verify Basic Functionality of Video Widget - muted. Which leads to flakiness. Also this case needs a human intervention to fulfilled the actual user case.
Solution: Deleted this test as it can be part of manual testing.
Fixes #36164
Automation
/ok-to-test tags="@tag.Widget"
:mag: Cypress test results
[!CAUTION] 🔴 🔴 🔴 Some tests have failed. Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10760787568 Commit: 11d8d952f5e24cc49056532b15da190eefe8ba41 Cypress dashboard. Tags: @tag.Widget Spec: The following are new failures, please fix them before merging the PR:
List of identified flaky tests.
- cypress/e2e/Regression/ClientSide/Debugger/Widget_property_navigation_spec.ts
- cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_Button_Icon_validation_spec.js
Sun, 08 Sep 2024 15:47:50 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Summary by CodeRabbit
-
Bug Fixes
- Removed a test case for the muted functionality of the Video Widget, streamlining the test suite.
-
Chores
- Updated the test path in the limited-tests file to prioritize video widget testing over template testing.
Walkthrough
The changes involve modifications to the Cypress test suite for the Video Widget, specifically the removal of a test case that verified the widget's functionality when muted. This led to a renumbering of the subsequent test cases. Additionally, the path for a test specification was updated in the limited-tests.txt file, shifting focus from template testing to video widget testing.
Changes
| Files | Change Summary |
|---|---|
app/client/cypress/e2e/Regression/ClientSide/Widgets/Video/Video2_Spec.ts |
Removed the test case for the Video Widget's muted functionality and renumbered subsequent tests. |
app/client/cypress/limited-tests.txt |
Updated the test path from template testing to video widget testing. |
Sequence Diagram(s)
(No sequence diagrams generated as the changes do not involve new features or modifications to control flow.)
Poem
In the land of tests, a change took flight,
A muted case vanished, no longer in sight.
The numbers shifted, a tidy new row,
Video widget's focus now takes center show.
With paths now aligned, the tests march ahead,
In the realm of code, new journeys are spread! 🎥✨
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai generate interesting stats about this repository and render them as a table. -
@coderabbitai show all the console.log statements in this repository. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
/ci-test-limit-count run_count=20
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/10740462665. Cypress dashboard PR: #36166.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10740462665. Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉
***** Repeat Run Summary ***** Total Tests with repeat: 120 Total Passed: 120 Total Failed: 0 Total Skipped: 0 *****************************