appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

feat: action redesign, UQI upgrade S3 plugin config to dual zone format & sorting field responsiveness

Open alex-golovanov opened this issue 1 year ago • 6 comments

Description

Upgrade S3 plugin config to new format using SECTION_V2, SINGLE_COLUMN_ZONE, and DOUBLE_COLUMN_ZONE.

Fixes #35484

Automation

/ok-to-test tags="@tag.All"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10720588484 Commit: c66dce69902ae247b6444ff901fe2cf1595e8e34 Cypress dashboard. Tags: @tag.All Spec:

Thu, 05 Sep 2024 15:04:31 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [x] No

Summary by CodeRabbit

  • New Features

    • Enhanced sorting control with improved performance and maintainability.
    • New configuration option for specifying the expiration duration of signed URLs in the Amazon S3 plugin.
    • Updated UI layout for various actions (upload, delete, read) in the Amazon S3 plugin to improve organization and user experience.
    • Clarified labeling and structure in the Amazon S3 plugin for better user interaction.

  • Bug Fixes

    • Streamlined logic for adding and deleting sorting fields in the sorting component.

  • Documentation

    • Updated control types and structure in the Amazon S3 plugin configuration for clarity and usability.

  • Style

    • Improved responsiveness of the sorting control layout and Amazon S3 plugin UI.

alex-golovanov avatar Sep 03 '24 14:09 alex-golovanov

Walkthrough

The changes encompass substantial updates to the Amazon S3 plugin's JSON configuration and the SortingControl component. Key modifications include the introduction of new control types, such as SECTION_V2 and DOUBLE_COLUMN_ZONE, which enhance the layout and organization of user interface elements. Additionally, the SortingControl component has been optimized for performance and type safety, improving its overall structure and functionality.

Changes

Files Change Summary
app/client/src/components/formControls/SortingControl.tsx Updated SortingControl to use useMemo, refined SortingComponent logic, improved styling and responsiveness.
app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/create.json Changed control types to SECTION_V2 and DOUBLE_COLUMN_ZONE, added new controls for signed URL expiration.
app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/create_many.json Similar changes as above, including new control for signed URL expiration and layout adjustments.
app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/delete.json Updated control types to SECTION_V2 and DOUBLE_COLUMN_ZONE, enhancing layout for DELETE_FILE action.
app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/delete_many.json Similar updates to control types and structure for DELETE_MULTIPLE_FILES action.
app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/list.json Control types changed to SECTION_V2, DOUBLE_COLUMN_ZONE, and SINGLE_COLUMN_ZONE, improving UI clarity.
app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/read.json Updated control types to SECTION_V2 and DOUBLE_COLUMN_ZONE, refining the READ_FILE functionality layout.
app/server/appsmith-plugins/amazons3Plugin/src/main/resources/editor/root.json Changed control type from SECTION to SECTION_V2, indicating a structural enhancement.

Assessment against linked issues

Objective Addressed Explanation
Add Zone & Section to Amazon S3 plugin form (#35484) ✅
Enhance layout and organization of controls (#35484) ✅
Introduce new functionality for signed URLs (#35484) ✅

Changes abound, a new dawn's light,
Zones and sections, a UI delight.
Controls refined, layout so neat,
Amazon S3, now can't be beat!
With each update, we take a leap,
In code we trust, our goals we keep. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 03 '24 14:09 coderabbitai[bot]

/build-deploy-preview skip-tests=true

alex-golovanov avatar Sep 03 '24 14:09 alex-golovanov

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10684757351. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 36090. recreate: .

github-actions[bot] avatar Sep 03 '24 14:09 github-actions[bot]

Deploy-Preview-URL: https://ce-36090.dp.appsmith.com

github-actions[bot] avatar Sep 03 '24 14:09 github-actions[bot]

Failed server tests

  • com.appsmith.server.solutions.ce.ActionExecutionSolutionCETest#executeActionNoStorageFound

github-actions[bot] avatar Sep 05 '24 08:09 github-actions[bot]

This PR has been tested on CE & EE (modules, workflows).

alex-golovanov avatar Sep 05 '24 09:09 alex-golovanov