appsmithorg
feat: action redesign, UQI upgrade AWS plugin config to dual zone format
Description
Upgrade AWS lambda plugin config to new format using SECTION_V2, SINGLE_COLUMN_ZONE, and DOUBLE_COLUMN_ZONE.
Fixes #35488
Automation
/ok-to-test tags="@tag.All"
:mag: Cypress test results
[!CAUTION] 🔴 🔴 🔴 Some tests have failed. Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10594312196 Commit: c56c1a811ad07d8a60463dfc89812b41a77b6416 Cypress dashboard. Tags: @tag.All Spec: The following are new failures, please fix them before merging the PR:
List of identified flaky tests.
- cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
- cypress/e2e/Regression/ServerSide/ApiTests/API_All_Verb_spec.js
Wed, 28 Aug 2024 10:45:26 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Summary by CodeRabbit
-
New Features
- Enhanced UI layout for the AWS Lambda plugin with a new dedicated section for handling post body configurations.
- Introduced a command selection mechanism to choose between listing functions and invoking a function, improving user interaction.
-
Improvements
- Updated control types to improve usability and presentation of the plugin's interface, including new layouts for function details and invocation options.
Walkthrough
The changes involve a substantial update to the JSON configuration for the AWS Lambda plugin, enhancing its structure by introducing new control types and sections. The top-level controlType has been updated to "SECTION_V2", with a new section labeled "POST_BODY" added to accommodate post body configuration. This reorganization aims to improve the layout and usability of the plugin's user interface.
Changes
| Files | Change Summary |
|---|---|
app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/invoke.json |
Updated controlType from "SECTION" to "SECTION_V2" and modified child control types. Added a new section for "POST_BODY" with its own layout. |
app/server/appsmith-plugins/awsLambdaPlugin/src/main/resources/editor/root.json |
Updated controlType from "SECTION" to "SECTION_V2" and added new control types for improved layout. Expanded command options for function management and added a conditional post body input section. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Add Zone & Section to AWS Lambda plugin form (##35488) | ✅ |
In JSON's dance, control types sway,
With"SECTION_V2"leading the way.
A"POST_BODY"zone joins the fun,
Enhancing the plugin for everyone! 🎉
Layouts reformed, usability bright,
A delightful change, bringing new light!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Early access features: disabled
We are currently testing the following features in early access:
- Anthropic
claude-3-5-sonnetfor code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.
Note:
- You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
- Please join our Discord Community to provide feedback and report issues on the discussion post.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10581783138.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 35912.
recreate: .
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10596745867.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 35912.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10635407593.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 35912.
recreate: .
Failed server tests
- com.appsmith.server.git.ServerSchemaMigrationEnforcerTest#saveGitRepo_ImportAndThenExport_diffOccurs
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10659564550.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 35912.
recreate: .