appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

feat: added differentiation between indian numeral system and international numeral system in currency input widget #28862

Open prasad-madine opened this issue 7 months ago • 10 comments

Issue Link

Description:

I have raised this PR to Add the Added Differentiation between Indian numeral system and International numeral system in currency input widget

The Currency Input widget currently formats numbers in a generic manner, without differentiating between the Indian numeral system and the International numeral system. This can lead to confusion and errors, particularly for users accustomed to a specific formatting style.

Cypress video

https://github.com/user-attachments/assets/5a48fc65-7c2c-40d7-9270-33b793923ec5

Screenshots:

Before resolving bug:

image (7)

After resolving bug:

Screenshot from 2024-07-26 10-19-08 Screenshot from 2024-07-26 10-19-26

Summary by CodeRabbit

  • New Features

    • Enhanced Currency Input Widget with improved currency formatting based on country code.
    • Added an end-to-end test suite for the Currency Input Widget to ensure proper numeral system differentiation.
  • Bug Fixes

    • Fixed validation logic in KeyValueComponent to ensure consistent error messaging for empty fields.
  • Documentation

    • Updated test coverage to include country-specific formatting for currency inputs.
  • Chores

    • Enhanced utility functions for locale-aware currency formatting.

prasad-madine avatar Jul 29 '24 11:07 prasad-madine