appsmith
appsmith copied to clipboard
chore: WDS spacing scale refinements
There is a number of things that should be improved regarding out inner and outer spacing:
- We apply ratios to V in the formula, perhaps it should be more than that because otherwise effects of theme ratios are a bit static/limited in effect.
- We have a bunch of values in the middle that we don't use (not as big of a problem). Outer spacing also doesn't use tokens smaller than 3 seemingly (this is more indicative of a problem). Overall steepness of curves as well as their formulas can/should change.
- Sometimes outer spacing is not exactly significantly bigger than inner one. See attached screenshot where spacing between input label and input is
inner-spacing-3
and between input widget and radio group widget it'souter-spacing-3
. They're ~9 and ~11 px respectively, optically seem the same. - We occasionally use impromer tokens, on the same screenshot space between radio group label and radios is defined with
outer-spacing-3
token instead of inner. - Changes to scale may require changing which tokens are used where especially in zones/sections/canvas.