appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: cypress snapshot types

Open KelvinOm opened this issue 8 months ago • 1 comments

Description

Fix the typing for matchImageSnapshot method. Change the method of comparing screenshots to ssim, since there should be less false positives with this method. More info here.

Automation

/ok-to-test tags="@tag.Anvil"

:mag: Cypress test results

[!CAUTION] 🔴 🔴 🔴 Some tests have failed. Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9714857408 Commit: d32cf9c3701c8947dfd8399b08e477ce867400f3 Cypress dashboard. Tags: @tag.Anvil The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Anvil/Widgets/AnvilInlineButtonWidgetSnapshot_spec.ts
List of identified flaky tests.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [x] No

Summary by CodeRabbit

  • New Features

    • Improved visual snapshot comparisons by introducing the ssim comparison method for enhanced accuracy.
  • Chores

    • Added @types/cypress-image-snapshot to dependencies.
    • Included a new script generate:anvil-snapshots for easier snapshot generation.

KelvinOm avatar Jun 27 '24 13:06 KelvinOm