appsmith
appsmith copied to clipboard
appsmithorg
feat: snowflake key auth server
Description
[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #Issue Number
or
Fixes Issue URL
[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
:mag: Cypress test results
[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
Walkthrough
The recent changes primarily enhance the SnowflakePlugin with improved authentication handling, including key pair and basic authentication methods. Additional utility functions were introduced to manage encrypted keys. The DatasourcesApi now ensures proper cleaning of authentication objects. Updates also included new error messages and adjustments to test configurations.
Changes
| Files | Change Summaries |
|---|---|
| app/client/src/api/DatasourcesApi.ts | Added a call to DatasourcesApi.cleanAuthenticationObject for the authentication object within datasourceConfiguration. |
| app/server/.../SnowflakePlugin.java | Various updates for handling authentication and datasource configurations, including imports and new methods for key handling. |
| app/server/.../exceptions/SnowflakeErrorMessages.java | Introduced new error messages related to passphrase requirements for encrypted private keys. |
| app/server/.../utils/SnowflakeKeyUtils.java | Added new file providing functionality to read encrypted private keys for Snowflake integration. |
| app/server/.../SnowflakePluginTest.java | Updated test configurations to set the authentication type to "dbAuth". |
Poem
Within the code, new paths align,
Snowflake's keys now safely shine. 🔑
Cleaned auth in Datasources made it clear,
Error messages whisper in our ear.
Integration stands robust and tall,
Like a mighty plugin, ready to enthrall. 🌟
[!WARNING]
Review ran into problems
Problems (1)
- Git: Failed to clone repository. Please contact CodeRabbit support.
[!TIP]
Early access features: enabled
We are currently testing the following features in early access:
- OpenAI
gpt-4omodel for code reviews and chat: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available.Note:
- You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
- Please join our Discord Community to provide feedback and report issues.
- OSS projects are currently opted into early access features by default.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9693303074.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34548.
recreate: .
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9694068032.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34548.
recreate: true.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9694734021.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34548.
recreate: true.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9738719690.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34548.
recreate: true.
Failed server tests
- com.appsmith.server.imports.internal.ImportServiceTests#discardChange_addNewActionAfterImport_addedActionRemoved
Also, can we please add some tests for the following cases:
- when passphrase is wrong for encrypted private key.
- when private key or passphrase is wrong
- positive successful test case with all the fields and no errors.
@NilanshBansal Will take this up separately as it may not be as straightforward as it looks.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9740276453.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34548.
recreate: true.
Failed server tests
- com.external.plugins.SnowflakePluginTest#testDatasourceWithInvalidUrl
Failed server tests
- com.appsmith.server.imports.internal.ImportServiceTests#discardChange_addNavigationSettingAfterAppPositioningAlreadyPresentInImport_addedNavigationSettingRemoved
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9741684547.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 34548.
recreate: true.