appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix:git connected app shows uncommitted changes sometimes even after …

Open Harshithazemoso opened this issue 1 year ago • 6 comments

…discard#33265

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #33265
or
Fixes https://github.com/appsmithorg/appsmith/issues/33265

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

:mag: Cypress test results

[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [ ] No

Video:Fixing the issue

Summary by CodeRabbit

  • New Features
    • Implemented a default timeout for action executions, enhancing reliability and performance by ensuring actions do not run indefinitely.

Harshithazemoso avatar Jun 26 '24 10:06 Harshithazemoso

Walkthrough

The recent update to the codebase involves setting the timeoutInMillisecond field within the ActionConfiguration class to a default value, ensuring consistent initialization. This change provides a default execution timeout for actions, enhancing the stability and predictability of action executions within the application.

Changes

File Change Summary
...ppsmith-interfaces/src/main/java/com/appsmith/external/models/ActionConfiguration.java Default value DEFAULT_ACTION_EXECUTION_TIMEOUT_MS assigned to timeoutInMillisecond field in ActionConfiguration class.

Poem

In the land of code, a change so bright,
A timeout set, to guide the flight.
Milliseconds tick in a gentle trance,
Ensuring actions have a fair chance.
With default set, no need to sway,
Let ActionConfiguration lead the way!
🌟🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Jun 26 '24 10:06 coderabbitai[bot]

/build-deploy-preview skip-tests=true

NilanshBansal avatar Jun 28 '24 07:06 NilanshBansal

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9709287698. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 34489. recreate: .

github-actions[bot] avatar Jun 28 '24 07:06 github-actions[bot]

Deploy-Preview-URL: https://ce-34489.dp.appsmith.com

github-actions[bot] avatar Jun 28 '24 07:06 github-actions[bot]

Tested and verified. Fix looks good to me

laveena-en avatar Jun 28 '24 08:06 laveena-en

@rohan-arthur can you please use the script to create a shadow pr in our repo so that we can run all the tests on this.

NilanshBansal avatar Jun 28 '24 09:06 NilanshBansal

Shadow PR here. https://github.com/appsmithorg/appsmith/pull/34600

NilanshBansal avatar Jul 01 '24 07:07 NilanshBansal

hello @NilanshBansal can I know the status of this pr ?

Harshithazemoso avatar Jul 02 '24 04:07 Harshithazemoso

Hey @Harshithazemoso thanks for taking out time to contribute to Appsmith. Unfortunately, the issue you were trying to resolve is not reproducible on appsmith production now. Ref: https://github.com/appsmithorg/appsmith/issues/33265#issuecomment-2201931393

I sincerely thank you for your attempt to solve this issue. In the future you can refer to our code contribution guidelines before starting off work on any issue, so you know the current status of the same.

Looking forward for more contributions from you 🙏

NilanshBansal avatar Jul 02 '24 06:07 NilanshBansal

Hey @Harshithazemoso thanks for taking out time to contribute to Appsmith. Unfortunately, the issue you were trying to resolve is not reproducible on appsmith production now. Ref: #33265 (comment)

I sincerely thank you for your attempt to solve this issue. In the future you can refer to our code contribution guidelines before starting off work on any issue, so you know the current status of the same.

Looking forward for more contributions from you 🙏

Yeah okay @NilanshBansal ,Thank you for your response

Harshithazemoso avatar Jul 02 '24 06:07 Harshithazemoso