appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

feat: clean up datasource review page

Open jacquesikot opened this issue 8 months ago • 4 comments

Description

Remove the "Generate new page" button from the datasource review page and make the "New Query" button a primary button. Tests related to the removed generate CRUD page feature have been removed.

Fixes #31801

Automation

/ok-to-test tags="@tag.Datasource"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9644141773 Commit: b1671022d7eee6a676103281dc2e7f5df8bfd513 Cypress dashboard. Tags: @tag.Datasource

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [ ] No

Summary by CodeRabbit

  • Bug Fixes

    • Removed outdated test cases that were no longer relevant or causing issues in MongoDB and S3 CRUD operations.

  • New Tests

    • Added HideGeneratePageButton.test.tsx to verify the visibility of buttons based on feature flags and user permissions.

  • Refactor

    • Improved code structure by reordering imports and simplifying logic in various datasource-related components.
    • Removed deprecated methods and functions related to page generation from datasource components.

jacquesikot avatar Jun 19 '24 13:06 jacquesikot