appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

chore: use overflow: auto instead of scroll in widget explorer

Open jsartisan opened this issue 9 months ago • 7 comments

image This PR adds overflow: auto instead of overflow: scroll. because of overflow:scroll, there is a reserve space at bottom for scrollbar even when it is not required.

jsartisan avatar May 10 '24 05:05 jsartisan

Walkthrough

Walkthrough

The recent updates aim to refine the user interface components in the application. This includes adjusting the scrolling behavior by updating the overflowX property in the AddWidgets component. Furthermore, a div element was substituted with a Flex component in the UIEntitySidebar, streamlining the layout and integrating more design system components for enhanced consistency and maintainability.

Changes

File Path Change Summary
.../EditorPane/UI/Add.tsx Changed overflowX from "scroll" to "auto" in AddWidgets component.
.../widgetSidebar/UIEntitySidebar.tsx Replaced a div with a Flex component, updated imports and element tags.
Recent Review Details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits Files that changed from the base of the PR and between 004c3ca62df5881ab7f50a59ed1c14e548dee94e and f7f68e7a7dcad13403b9b319ebefeb9b901de966.
Files selected for processing (2)
  • app/client/src/pages/Editor/IDE/EditorPane/UI/Add.tsx (1 hunks)
  • app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx (3 hunks)
Files skipped from review as they are similar to previous changes (2)
  • app/client/src/pages/Editor/IDE/EditorPane/UI/Add.tsx
  • app/client/src/pages/Editor/widgetSidebar/UIEntitySidebar.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 10 '24 05:05 coderabbitai[bot]

/build-deploy-preview skip-tests=true env=release

jsartisan avatar May 10 '24 05:05 jsartisan

/build-deploy-preview skip-test=true

albinAppsmith avatar May 10 '24 05:05 albinAppsmith

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9027560069. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: release. PR: 33342. recreate: .

github-actions[bot] avatar May 10 '24 05:05 github-actions[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9027562253. Workflow: On demand build Docker image and deploy preview. skip-tests: . env: . PR: 33342. recreate: .

github-actions[bot] avatar May 10 '24 05:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-a4zromm6c-get-appsmith.vercel.app

🚨 Note: The release environment runs EE code, so using a frontend-only DP on this repo, will likely behave unexpectedly. Consider using a full DP instead. Learn more.

github-actions[bot] avatar May 10 '24 05:05 github-actions[bot]

Deploy-Preview-URL: https://ce-33342.dp.appsmith.com

github-actions[bot] avatar May 10 '24 05:05 github-actions[bot]