chore: Remove unnecessary flag `ab_show_templates_instead_of_blank_canvas_enabled`

[rahulbarwal]

Description

Additonally this pull request removes the unnecessary checks inside the Onboarding component by importing the isDraggingBuildingBlockToCanvas function from selectors/buildingBlocksSelectors and using it to determine if any building blocks are being dragged. --> IT is already being checked in DropTargetComponent.tsx which renderst this Onboarding component.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Templates, @tag.Datasource"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9013874763 Commit: 7f53881efa277883d006d9a2ed45a887dc6f2d47 Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

• [ ] Yes
• [x] No

[coderabbitai[bot]]

Walkthrough

The recent updates primarily focus on refining feature flag usage and enhancing UI responsiveness related to drag-and-drop functionalities. Key changes include the removal of specific feature flags affecting canvas behavior, simplification of conditions for UI component display in the onboarding process, and a more integrated handling of widget and building block drag states. These alterations aim to streamline user experience and code maintainability.

Changes

File Path	Change Summary
.../Onboarding/StartFromData_spec.ts .../Templates/BuildingBlocks/StarterBuildingBlocksOnCanvas_spec.ts	Removed specific feature flag calls in test setups.
.../src/ce/entities/FeatureFlag.ts .../PartialImportExport/PartialExportModal/unitTestUtils.ts	Removed declarations of ab_show_templates_instead_of_blank_canvas_enabled flag.
.../dropTarget/DropTargetComponent.tsx	Enhanced drag state handling by integrating widget and building block drag states.
.../dropTarget/OnBoarding/index.tsx .../dropTarget/OnBoarding/OnBoarding.test.tsx	Refactored onboarding logic and tests, removing unused selectors and simplifying conditions. Adjusted tests for different operational modes (AirGap, Mobile, etc.).

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.