appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

fix: remove granular status feature flag

Open brayn003 opened this issue 9 months ago • 4 comments

Description

Removes release_git_status_granular_enabled feature flag

Fixes #33287

Automation

/ok-to-test tags="@tag.Git"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9018396111 Commit: a2af6687222992a2b5884a4c6086ad95b951535c Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [ ] No

brayn003 avatar May 08 '24 10:05 brayn003

/build-deploy-preview skip-tests=true

brayn003 avatar May 09 '24 06:05 brayn003

Walkthrough

Walkthrough

The recent code changes primarily focus on removing the release_git_status_granular_enabled feature flag and optimizing code structure within the GitChangesList component for better maintainability. These changes aim to streamline feature flag management and enhance component organization.

Changes

File Path Change Summary
.../src/ce/entities/FeatureFlag.ts Removed release_git_status_granular_enabled from constants.
.../src/pages/Editor/gitSync/Tabs/__tests__/Deploy.test.tsx Removed imports and dispatch related to the feature flag in tests.
.../src/pages/Editor/gitSync/components/GitChangesList/index... Updated imports, restructured components, and removed feature flag usage.

Assessment against linked issues

Objective Addressed Explanation
Remove release_git_status_granular_enabled [#33287] The specific feature flag has been successfully removed as per the linked issue's task.
Address failures in Cypress test suite [#30378] The changes could potentially impact Cypress tests, but the resolution details are not explicitly provided. Further clarification is needed for full compliance.

Possibly related issues

  • appsmithorg/appsmith#30961: While the current changes focus on a different flag, the overarching goal of simplifying feature flag management aligns with the objective of removing various git-related feature flags. There is a potential link if the flag removal scope expands.

Recent Review Details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits Files that changed from the base of the PR and between 3366b0b5dd28d4f014ab22cccd604a38eff45b46 and a2af6687222992a2b5884a4c6086ad95b951535c.
Files selected for processing (2)
  • app/client/src/pages/Editor/gitSync/components/GitChangesList/StaticChange.tsx (1 hunks)
  • app/client/src/pages/Editor/gitSync/components/GitChangesList/index.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
  • app/client/src/pages/Editor/gitSync/components/GitChangesList/StaticChange.tsx
Files skipped from review as they are similar to previous changes (1)
  • app/client/src/pages/Editor/gitSync/components/GitChangesList/index.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 09 '24 06:05 coderabbitai[bot]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9013453406. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 33288. recreate: .

github-actions[bot] avatar May 09 '24 06:05 github-actions[bot]

Deploy-Preview-URL: https://ce-33288.dp.appsmith.com

github-actions[bot] avatar May 09 '24 06:05 github-actions[bot]