appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix: allowing bottom tabs to be selectable as text

Open AmanAgarwal041 opened this issue 1 year ago • 12 comments

Description

Enabling the bottom tabs overall for users to select the test for errors, response, logs etc. The tailwind css class select-none which was added to the whole of the application was getting applied to this area as well by inheriting the properties. Added select-text property which enables the user to select anything inside the container as text.

Fixes #32755 or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Debugger"

:mag: Cypress test results

[!CAUTION] 🔴 🔴 🔴 Some tests have failed. Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9033102637 Commit: 7092a21ed22c80798d55d602c07a526d722f05d8 Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL2_Spec.ts
To know the list of identified flaky tests - Refer here

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [ ] No

AmanAgarwal041 avatar May 08 '24 06:05 AmanAgarwal041

Walkthrough

The recent changes involve adding the select-text class to the className attributes of various components to enable text selection in different views like API response, JS response, debugger, and query debugger tabs. New test cases have been introduced to verify the presence and functionality of the select-text class. Additionally, a new tag has been included in the Cypress configuration for better test categorization.

Changes

File Path Change Summary
.../ApiResponseView.tsx, .../JSResponseView.tsx,
.../Debugger.tsx, .../QueryDebuggerTabs.tsx		 Added select-text class to className attributes in components for text selection.
.../cypress/tags.js Added @tag.Debugger for test categorization.
.../ApiResponseView.test.tsx, .../JSResponseView.test.tsx,
.../Debugger.test.tsx, .../QueryDebuggerTabs.test.tsx		 Introduced new test cases to validate the select-text class functionality.

Assessment against linked issues

Objective Addressed Explanation
[Bug]: error log is not copy-able (#32755) ✅ The addition of the select-text class enables text selection, allowing users to copy error logs, addressing the issue of error log not being copy-able.

The changes align with the requirements outlined in the linked issue by enhancing user experience through text selection capabilities, resolving the regression where copying error logs was not possible directly from the UI.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 08 '24 06:05 coderabbitai[bot]

/build-deploy-preview skip-tests=true recreate=true

AmanAgarwal041 avatar May 08 '24 07:05 AmanAgarwal041

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8997713589. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 33263. recreate: true.

github-actions[bot] avatar May 08 '24 07:05 github-actions[bot]

Deploy-Preview-URL: https://ce-33263.dp.appsmith.com

github-actions[bot] avatar May 08 '24 07:05 github-actions[bot]

/build-deploy-preview skip-tests=true

AmanAgarwal041 avatar May 08 '24 08:05 AmanAgarwal041

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8998822590. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 33263. recreate: .

github-actions[bot] avatar May 08 '24 08:05 github-actions[bot]

Deploy-Preview-URL: https://ce-33263.dp.appsmith.com

github-actions[bot] avatar May 08 '24 08:05 github-actions[bot]

/build-deploy-preview skip-tests=true

sneha122 avatar May 10 '24 06:05 sneha122

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9028447050. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 33263. recreate: .

github-actions[bot] avatar May 10 '24 06:05 github-actions[bot]

Deploy-Preview-URL: https://ce-33263.dp.appsmith.com

github-actions[bot] avatar May 10 '24 07:05 github-actions[bot]

@AmanAgarwal041 Tested the changes, looks good, noticed one thing though, in error tabs the cursor does not change to selection one, it stays as default. Please check

https://github.com/appsmithorg/appsmith/assets/30018882/5035c355-8ce6-4968-a09f-41f1a4329139

sneha122 avatar May 10 '24 07:05 sneha122

@AmanAgarwal041 Tested the changes, looks good, noticed one thing though, in error tabs the cursor does not change to selection one, it stays as default. Please check

Screen.Recording.2024-05-10.at.12.52.07.PM.mov

Multiple components collapsible, json viewer etc inside this have cursor: default so I think its better to leave this till the text is getting selected. @sneha122

AmanAgarwal041 avatar May 10 '24 11:05 AmanAgarwal041