appsmithorg
feat: New tab ui changes
Description
Added new design of New Query/Js tab design.
Fixes #33116
Automation
/ok-to-test tags="@tag.Sanity, @tag.IDE"
:mag: Cypress test results
[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9028800221 Commit: ae5654eb821269e342520408e5058bba148116f0 Cypress dashboard url: Click here!
Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [ ] No
Walkthrough
Walkthrough
The recent updates to the IDE module's EditorPane involve refining import statements, enhancing route configurations, and improving description rendering logic. Specifically, hooks.tsx in both the Query and JS directories received modifications to streamline imports, adjust route paths, and optimize conditional logic.
Changes
| Files | Change Summary |
|---|---|
.../EditorPane/Query/hooks.tsx |
- Replaced individual React hooks imports with a single React import. |
- Updated import statement for ListItemProps to include Tag and specify the type. |
|
- Adjusted route configuration for ListQuery component. |
|
- Enhanced description rendering logic in useAddQueryListItems. |
|
.../EditorPane/JS/hooks.ts |
- Updated route configuration in useJSSegmentRoutes to include additional paths. |
- Optimized early return condition in useJSAdd function. |
|
.../Regression/ClientSide/IDE/IDE_Add_Pane_Interactions_spec.ts |
- Modified closeAddView() calls to include PagePaneSegment argument. |
.../support/Pages/IDE/AddView.ts |
- Added addPane locator and adjusted visibility check in assertInAddView. |
.../support/Pages/IDE/LeftPane.ts |
- Added imports for PagePaneSegment and FileTabs. |
- Modified closeAddView method to accept a segment parameter. |
Assessment against linked issues
| Objective (Issue #) | Addressed | Explanation |
|---|---|---|
| Render add button as an active tab (#33116) | ✅ | |
Adjust route configurations for ListJS and ListQuery components (#33116) |
✅ | |
Optimize conditional logic in useJSAdd function (#33116) |
✅ |
Recent Review Details
Configuration used: CodeRabbit UI Review profile: CHILL
Commits
Files that changed from the base of the PR and between ea658d0757f61298c8dfb566de67e5afabcdc22d and 48223f4aecb77cd98e1bfea1c0ffc5710689509a.Files selected for processing (1)
- app/client/cypress/support/Pages/EntityExplorer.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/client/cypress/support/Pages/EntityExplorer.ts
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai generate interesting stats about this repository and render them as a table. -
@coderabbitai show all the console.log statements in this repository. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8984640047.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33228.
recreate: .
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9015505258.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33228.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9028798147.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33228.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9077292875.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33228.
recreate: .