appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

chore: Splitting JS Object body dump vs parsed JS Object update to remove race condition originated bad state

Open trishaanand opened this issue 1 year ago • 14 comments

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

:mag: Cypress test results

[!TIP] 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9029211697 Commit: 190f7682cad3117e776d94f1502609026633369c Cypress dashboard url: Click here!

Communication

Should the DevRel and Marketing teams inform users about this change?

  • [ ] Yes
  • [ ] No

trishaanand avatar May 02 '24 07:05 trishaanand

Walkthrough

Walkthrough

The recent updates focus on enhancing JavaScript collection management and action collection handling. New methods for updating JS collection bodies and unpublished action collections have been introduced, improving specificity and efficiency. Changes also involve refactoring existing functionalities and updating method signatures to streamline processes and integrate new logic, ensuring a more robust and flexible system.

Changes

File Path Change Summary
app/client/src/ce/api/JSActionAPI.tsx Added updateJSCollectionBody method for updating JavaScript collection bodies via PUT requests.
app/client/src/sagas/JSPaneSagas.ts Modified handleUpdateJSCollectionBody to use updateJSCollectionBody. Changed response type and updated logic for handling collection updates.
app/server/.../services/ce/LayoutCollectionServiceCEImpl.java Added new methods and refactored existing ones for better management of action collections. Updated method signatures and integrated new logic for resource handling.
Recent Review Details

Configuration used: CodeRabbit UI Review profile: CHILL

Commits Files that changed from the base of the PR and between edf5662d904fd1b11bd454d46cff3fa0c5a8b452 and 190f7682cad3117e776d94f1502609026633369c.
Files selected for processing (1)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/LayoutCollectionServiceCEImpl.java (6 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/LayoutCollectionServiceCEImpl.java

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 02 '24 07:05 coderabbitai[bot]

Failed server tests

  • com.appsmith.server.solutions.CreateDBTablePageSolutionTests#createPageWithLessColumnsComparedToTemplateForSql

github-actions[bot] avatar May 02 '24 07:05 github-actions[bot]

Failed server tests

  • com.appsmith.server.solutions.CreateDBTablePageSolutionTests#createPageWithInvalidApplicationIdTest

github-actions[bot] avatar May 02 '24 07:05 github-actions[bot]

QQ: Doesn't this PR need the client-side changes w.r.t. modules and workflows? @trishaanand Asking this because there is JS object in both workflows and modules.

subrata71 avatar May 09 '24 12:05 subrata71

QQ: Doesn't this PR need the client-side changes w.r.t. modules and workflows? @trishaanand Asking this because there is JS object in both workflows and modules.

@ApekshaBhosale : Is this correct? Do we need changes in modules and workflows code flow as well?

trishaanand avatar May 09 '24 12:05 trishaanand

@trishaanand i don't think so because underline uses same JS objects.it will be fine! @ayushpahwa can you confirm once?

ApekshaBhosale avatar May 09 '24 12:05 ApekshaBhosale

@trishaanand checked code for workflow as well. looks like it uses same underline js object so it will be fine!

ApekshaBhosale avatar May 09 '24 12:05 ApekshaBhosale

/build-deploy-preview skip-tests=true

dvj1988 avatar May 09 '24 13:05 dvj1988

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9018338440. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 33124. recreate: .

github-actions[bot] avatar May 09 '24 13:05 github-actions[bot]

Deploy-Preview-URL: https://ce-33124.dp.appsmith.com

github-actions[bot] avatar May 09 '24 14:05 github-actions[bot]

@dvj1988 @trishaanand format of JS object body is different so regex is failing on client side. extra "/" i see

ApekshaBhosale avatar May 09 '24 15:05 ApekshaBhosale

/build-deploy-preview skip-tests=true

dvj1988 avatar May 10 '24 07:05 dvj1988

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9028726207. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 33124. recreate: .

github-actions[bot] avatar May 10 '24 07:05 github-actions[bot]

Deploy-Preview-URL: https://ce-33124.dp.appsmith.com

github-actions[bot] avatar May 10 '24 07:05 github-actions[bot]