appsmithorg
feat: font update - PT root UI medium
Description
This PR update default font to PT Root UI.
Fixes #32720
Automation
/ok-to-test tags="@tag.Sanity"
:mag: Cypress test results
[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No
Summary by CodeRabbit
-
Style
- Removed font smoothing properties from the body styling to enhance text clarity and appearance across web browsers.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8874024992.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Walkthrough
Walkthrough
The changes encompass standardizing font families across multiple files by utilizing the custom CSS variable --ads-v2-font-family, facilitating global font management and consistency. This initiative supports the broader objective of transitioning to the PT Root UI font system for a cohesive user experience.
Changes
| File Path | Change Summary |
|---|---|
app/client/public/404.css, app/client/public/content.css |
Updated font-family to use var(--ads-v2-font-family) instead of specific font families. |
app/client/src/components/editorComponents/Debugger/ErrorLogs/components/LogCollapseData.tsx, app/client/src/components/editorComponents/Debugger/ErrorLogs/components/LogItem.tsx |
Replaced predefined font stacks with var(--ads-v2-font-family) in reactJsonProps objects. |
app/client/src/constants/Fonts.tsx |
Updated TextFonts constant to use var(--ads-v2-font-family) for font family definition. |
app/client/src/index.css |
Removed -webkit-font-smoothing: antialiased; and -moz-osx-font-smoothing: grayscale; from body styling. |
Possibly related issues
- appsmithorg/appsmith#32720: The updates to the font families using a custom variable are in line with the goal of switching to the PT Root UI font, ensuring a consistent font experience throughout the application.
Recent Review Details
Configuration used: CodeRabbit UI Review profile: CHILL
Commits
Files that changed from the base of the PR and between 0da712b1088482649f1d106d2d54dfdff79a98d0 and 491aaf0d92f123482c88c6ec13999e0356dbea53.Files ignored due to path filters (2)
-
app/client/package.jsonis excluded by!**/*.json -
app/client/yarn.lockis excluded by!**/*.lock,!**/*.lock
Files selected for processing (1)
- app/client/src/index.css (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/client/src/index.css
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai generate interesting stats about this repository and render them as a table. -
@coderabbitai show all the console.log statements in this repository. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8876986562.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8889986084.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8891062165.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8921877654.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9001222877.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 33008.
recreate: .