fix: dependencyMap optimisations

[vsvamsi1]

Description

[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

:mag: Cypress test results

[!WARNING] Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9001340474 Commit: 4f679a7282487dafa854aefe6a075afbb76a2203 Cypress dashboard url: Click here! It seems like no tests ran 😔. We are not able to recognize it, please check workflow here.

Communication

Should the DevRel and Marketing teams inform users about this change?

• [ ] Yes
• [ ] No

Summary by CodeRabbit

• New Features
  • Enhanced dependency management capabilities with the introduction of new methods to efficiently update and manage node dependencies.
• Improvements
  • Updated existing methods in the DependencyMap to handle additional node information and improve the accuracy of dependency tracking.
• Refactor
  • Optimized dependency update processes to be more responsive to changes within node collections.

[coderabbitai[bot]]

Walkthrough

The updates involve enhancing dependency management in the DependencyMap classes by introducing new methods and refining existing ones. These changes aim to improve the tracking and updating of node dependencies, ensuring more robust and efficient dependency handling across different components of the application.

Changes

File Path	Change Summary
.../DependencyMap/DependencyMapUtils.ts	Added makeParentsDependOnChildCollection method; minor formatting update.
.../DependencyMap/index.ts	Updated addDependency method to return additional nodes; adjusted removeDependency method return.
.../workers/common/DependencyMap/index.ts	Enhanced updateDependencyMap function to handle arrays and introduced new logic for dependency updates.

Possibly related issues

• appsmithorg/appsmith#30378: The enhancements in dependency management might address issues with test failures related to dependency tracking in PR #29794. The improvements ensure more accurate and efficient dependency handling, which could potentially resolve related test suite failures.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rajatagrawal]

@vsvamsi1 Can we please have test cases for this refactoring ?

[vsvamsi1]

@rishabhrathod01 adding reactivePaths instead of bindingPaths has caused multiple failures. I have reverted that back.

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[github-actions[bot]]

This PR has been closed because of inactivity.