appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

test: Test/fix tree select2

Open NandanAnantharamu opened this issue 10 months ago • 155 comments

RCA: Toggle js is not working on some ocassions as result test is flaky Adding validation to make sure the toggle js is enabled and then proceed

Summary by CodeRabbit

  • Tests
    • Enhanced test scenarios to assert the state of JavaScript toggles in the Tree Select widget.
  • New Features
    • Introduced a method to toggle and verify JavaScript mode in the Property Pane.

NandanAnantharamu avatar Apr 23 '24 08:04 NandanAnantharamu

Walkthrough

The changes involve enhancing Cypress testing for the TreeSelect widget and PropertyPane class. This includes adding functionality to toggle JavaScript mode and verifying its state, as well as refining tests to assert the JavaScript toggle's state based on specific conditions.

Changes

File Path Change Summary
.../cypress/e2e/.../TreeSelect/Tree_Select_2_spec.ts Asserted JS toggle state as "enabled" or "disabled" in test scenarios. Stubbed window.open to prevent new tabs. Changed spec file path.
.../cypress/support/Pages/PropertyPane.ts Added ToggleJS method to manage and verify JavaScript mode toggling.

Possibly related issues

  • appsmithorg/appsmith#30378: The enhancements in this PR could potentially address test failures related to the JS toggle functionality, aligning with the objectives outlined in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Apr 23 '24 08:04 coderabbitai[bot]

/ci-test-limit

NandanAnantharamu avatar Apr 23 '24 08:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 10:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 10:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8799264881. Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉

github-actions[bot] avatar Apr 23 '24 11:04 github-actions[bot]

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8799744307. Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉

github-actions[bot] avatar Apr 23 '24 11:04 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8799742043. Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉

github-actions[bot] avatar Apr 23 '24 11:04 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8799743036. Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉

github-actions[bot] avatar Apr 23 '24 11:04 github-actions[bot]

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu

/ci-test-limit runId=8797277577

NandanAnantharamu avatar Apr 23 '24 11:04 NandanAnantharamu