Remove hardcoding of RTS server
Description
Removes the hardcoded RTS server url. Please double check to see that the value with the ':' in the annotations you are using will work, as I don't write java frequently.
Fixes #32532
Automation
/ok-to-test tags=""
:mag: Cypress test results
[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Summary by CodeRabbit
- New Features
- Enhanced server configuration to support a new Real-Time Service (RTS) base URL setup.
Walkthrough
The changes involve updating the configuration management in the Appsmith server code to dynamically set the Realtime Server (RTS) host URL. A new field and property have been introduced to replace the previously hardcoded RTS URL, enhancing flexibility for deployments, particularly in containerized environments.
Changes
| File Path | Change Summary |
|---|---|
.../appsmith-server/src/main/java/.../CommonConfig.java |
Added rtsHost field; updated getRtsBaseUrl to construct URL from rtsHost and rtsPort. |
.../appsmith-server/src/main/resources/.../application.properties |
Added appsmith.rts.host property with default value http://127.0.0.1. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Remove hardcoded RTS server URL (#32532) | ✅ |
Possibly related issues
- appsmithorg/appsmith#30548: The issue discusses a hardcoded RTS service host and port which the current PR addresses by allowing dynamic setting through environment variables. This change directly relates to the concerns raised in the issue.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
This feels like this should be a relatively easy merge
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
Please review, this is a simple PR
@nidhi-nair @sondermanish
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
@nilanshbansal Please provide a review of this very simple PR
@sharat87 @brayn003 can you please check this out.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.