appsmith
appsmith copied to clipboard
fix: Checkbox type column on a table misalignment
Description
[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content team).Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #21790
or
Fixes Issue URL
[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Media : https://www.loom.com/share/ed1527330fc74c29ac1befb648aeb34f?sid=070dc600-ca1a-40d3-86bd-60767de0987e
Automation
/ok-to-test tags="@tag.Table"
:mag: Cypress test results
[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Walkthrough
The change adjusts the width
property of the CheckboxContainer
in the CheckboxWidget
component from 100%
to auto
. This alteration is likely aimed at addressing alignment issues within the widget.
Changes
File Path | Change Summary |
---|---|
app/client/src/widgets/CheckboxWidget/.../index.tsx |
Changed width from 100% to auto in CheckboxContainer |
Assessment against linked issues
Objective | Addressed | Explanation |
---|---|---|
Ensure checkbox icon is centered in Checkbox type column when alignment is centered (#21790) | ✅ | |
Address checkbox alignment within the MultiSelect widget (#24111) | ❌ | The change is specific to the CheckboxWidget, not MultiSelect. |
Resolve UI issues on mobile and tablet devices for WDS widgets (#29161) | ❌ | The change does not relate to mobile/tablet UI or WDS widgets. |
Possibly related issues
- appsmithorg/appsmith#24111: Although this issue deals with checkbox alignment, it specifically targets the MultiSelect widget, not the CheckboxWidget. The current PR does not address MultiSelect widget issues.
- appsmithorg/appsmith#29161: This issue is focused on UI problems with WDS widgets on mobile and tablet devices. The change in this PR does not pertain to mobile UI issues or WDS widgets, hence it is unrelated.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>.
-
Generate unit testing code for this file.
-
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitai
in a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file.
-
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitai
in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai generate interesting stats about this repository and render them as a table.
-
@coderabbitai show all the console.log statements in this repository.
-
@coderabbitai read src/utils.ts and generate unit testing code.
-
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
-
@coderabbitai pause
to pause the reviews on a PR. -
@coderabbitai resume
to resume the paused reviews. -
@coderabbitai review
to trigger a review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai resolve
resolve all the CodeRabbit review comments. -
@coderabbitai help
to get help.
Additionally, you can add @coderabbitai ignore
anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml
)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yaml
file to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
/build-deploy-preview skip-tests=true
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8657212611.
Workflow: On demand build Docker image and deploy preview
.
skip-tests: true
.
env: ``.
PR: 32627.
recreate: .
Deploy-Preview-URL: https://ce-32627.dp.appsmith.com
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
Hello @akshat8605, just checking in with you if you need any additional help as it's been a while since our last discussion.
Hi @ashit-rath, I am on a vacation I will be back by tomorrow and will continue working!
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
This PR has been closed because of inactivity.