appsmith
appsmith copied to clipboard
appsmithorg
fix: JSON form splits keys to multiple lines when it should not
Description
[!TIP]
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content team).Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #32230
or
Fixes https://github.com/appsmithorg/appsmith/issues/32230
[!WARNING]
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.JSONForm"
:mag: Cypress test results
[!CAUTION]
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Summary by CodeRabbit
-
Style Updates
- Improved label display in JSON Form Widget to prevent text wrapping.
- Adjusted the width setting of the Switch Widget for better layout consistency.
Walkthrough
Walkthrough
The changes involve adjusting the CSS styling in two components - FieldLabel.tsx in the JSONFormWidget and the SwitchWidget component. These modifications aim to enhance the visual presentation of labels by preventing text wrapping and ensuring the appropriate width for better alignment.
Changes
| File Path | Change Summary |
|---|---|
app/client/src/widgets/JSONFormWidget/.../FieldLabel.tsx |
Added flex: 1; to StyledLabelTextWrapper styling Added white-space: nowrap; to StyledLabelText styling |
app/client/src/widgets/SwitchWidget/component/index.tsx |
Changed width property from 100% to auto |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Prevent key labels from wrapping onto multiple lines in JSONFormWidget (#32230) | ✅ | |
| Ensure correct display of WDS widgets on mobile and tablet devices (#29161) | ❌ | Adjustments in SwitchWidget may not directly address WDS widget display issues on mobile and tablet devices. |
Possibly related issues
-
appsmithorg/appsmith#29161: The changes in
SwitchWidgetmay not directly resolve issues related to widget display on mobile and tablet devices as described in this issue. - appsmithorg/appsmith#10165: Unlikely related as the issue pertains to text overlap in property fields, not directly linked to CSS styling for text wrapping or width adjustments.
Recent Review Details
Configuration used: CodeRabbit UI
Commits
Files that changed from the base of the PR and between eb4a492042c9115aa733deea3109fcf8ed60ae51 and c52a586b00393ca5fdadcca2dcf422c56845128a.Files selected for processing (2)
- app/client/src/widgets/JSONFormWidget/component/FieldLabel.tsx (1 hunks)
- app/client/src/widgets/SwitchWidget/component/index.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/client/src/widgets/JSONFormWidget/component/FieldLabel.tsx
Additional comments not posted (1)
app/client/src/widgets/SwitchWidget/component/index.tsx (1)
42-42: Change in width property from100%toauto.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai generate interesting stats about this repository and render them as a table. -
@coderabbitai show all the console.log statements in this repository. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger a review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
![coderabbitai[bot] avatar](https://avatars.githubusercontent.com/in/347564?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8657212467.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 32626.
recreate: .
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@ashit-rath I have implemented the changes. As suggested, I have set the width of the switch to auto and the label to flex 1.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8732612536.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 32626.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8748764799.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 32626.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8782079173.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 32626.
recreate: .
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.