appsmith
appsmith copied to clipboard
fix: label appsmith k8s resources using commonLabels from values.yaml
Description
The customLabels in values.yaml do not label the appsmith k8s resources as expected.
This PR fixes it.
Fixes #32232 Fixes Issue URL
Summary by CodeRabbit
- New Features
- Enhanced Helm chart by adding conditional rendering for common labels, improving customization and flexibility.
- Updated version number in
Chart.yamlto2.0.8for the latest changes.
Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.
Walkthrough
The update enhances the Helm chart by implementing conditional rendering of common labels based on .Values.commonLabels. Additionally, a new label inclusion for appsmith.labels has been added to the statefulset.yaml file, improving resource labeling consistency and configurability.
Changes
| File | Change Summary |
|---|---|
deploy/helm/Chart.yaml |
Updates the version number in Chart.yaml from 2.0.7 to 2.0.8. |
deploy/helm/templates/_helpers.tpl |
Introduces conditional rendering of .Values.commonLabels with adjusted YAML indentation. |
deploy/helm/templates/statefulset.yaml |
Adds a new label inclusion for appsmith.labels within the spec section. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
| Implement commonLabels feature for consistent resource labeling | ✅ |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai generate interesting stats about this repository and render them as a table.@coderabbitai show all the console.log statements in this repository.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (invoked as PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
CodeRabbit Configration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Can you bump the version in Chart.yaml
Can you bump the version in Chart.yaml
Done.
And I'll ignore CoderabbitAI suggestion cause indentation is not needed in this define "appsmith.labels" block.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
I guess it needs finishing review and approval ^^
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
It's ready to be merged and was already approved once before :)