appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

feat: workflows assign request on browser

Open ayushpahwa opened this issue 1 year ago β€’ 1 comments

Pull Request Template

Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.

Description

Add a TL;DR when description is extra long (helps content team)

Please include a summary of the changes and which issue has been fixed. Please also include relevant motivation and context. List any dependencies that are required for this change

Links to Notion, Figma or any other documents that might be relevant to the PR

PR fixes following issue(s)

Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [ ] Manual
  • [ ] JUnit
  • [ ] Jest
  • [ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

  • New Features
    • Enhanced autocomplete functionality in the app with new workflow definitions.
  • Refactor
    • Improved function handling for better app performance and maintainability.
  • Bug Fixes
    • Resolved errors caused by undefined variables in JavaScript actions.

ayushpahwa avatar Feb 15 '24 14:02 ayushpahwa

Walkthrough

Walkthrough

The updates encompass enhancements to autocomplete functionality, the introduction of a new enum for namespaced functions, and refinements in state management within reducers. Specifically, these changes involve the integration of new autocomplete definitions for workflows and app-specific functions, the establishment of a GROUP_TYPES enum for better categorization in the Explorer, and adjustments in the JavaScript actions reducer to handle new properties more effectively.

Changes

File Path Change Summary
.../src/ce/entities/Engine/actionHelpers.ts Introduced an empty enum APPSMITH_NAMESPACED_FUNCTIONS.
.../src/ce/utils/autocomplete/EntityDefinitions.ts Added new imports and updated entityDefinitions with workflow and app-specific autocomplete defs.
.../src/ce/utils/workflowHelpers.ts Added a function workflowAutocompleteDefinitions returning an empty object.
.../src/components/editorComponents/ActionCreator/constants.ts Imported APPSMITH_NAMESPACED_FUNCTIONS and included it in AppsmithFunction enum.
.../src/ce/reducers/entityReducers/jsActionsReducer.tsx Updated property assignments to include isMainJSCollection and enhance state updates.
.../src/ce/utils/autocomplete/helpers.ts Introduced a file for defining autocomplete definitions.
.../src/ee/utils/autocomplete/helpers.ts Exported functionality from the CE version of autocomplete/helpers.
.../src/ce/pages/Editor/Explorer/helpers.tsx Added GROUP_TYPES enum and updated ExplorerFileEntity interface.
.../src/ce/selectors/entitiesSelector.ts Added GROUP_TYPES enum for group categorization and refactored group assignments.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Feb 15 '24 14:02 coderabbitai[bot]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

github-actions[bot] avatar Feb 24 '24 16:02 github-actions[bot]

/ok-to-test tags="@tag.Sanity @tag.JS"

ayushpahwa avatar Feb 26 '24 15:02 ayushpahwa

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8051719111. Workflow: Appsmith External Integration Test Workflow. Tags: @tag.Sanity @tag.JS.

github-actions[bot] avatar Feb 26 '24 15:02 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8051719111. Commit: ``. Cypress dashboard url: Click here! All cypress tests have passed πŸŽ‰πŸŽ‰πŸŽ‰

github-actions[bot] avatar Feb 26 '24 16:02 github-actions[bot]

/ok-to-test tags="@tag.Sanity @tag.JS"

ayushpahwa avatar Mar 04 '24 09:03 ayushpahwa

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8138346040. Workflow: Appsmith External Integration Test Workflow. Tags: @tag.Sanity @tag.JS.

github-actions[bot] avatar Mar 04 '24 09:03 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8138346040. Commit: ``. Cypress dashboard url: Click here! All cypress tests have passed πŸŽ‰πŸŽ‰πŸŽ‰

github-actions[bot] avatar Mar 04 '24 10:03 github-actions[bot]