chore: git continuous delivery automation tests

[brayn003]

Description

Adds automation tests for Git continuous delivery

PR fixes following issue(s)

Fixes #31130

Type of change

• Chore (housekeeping or task changes that don't impact user perception)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

• [ ] Manual
• [ ] JUnit
• [ ] Jest
• [ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] PR is being merged under a feature flag

QA activity:

• [ ] Speedbreak features have been covered
• [ ] Test plan covers all impacted features and areas of interest
• [ ] Test plan has been peer reviewed by project stakeholders and other QA members
• [ ] Manually tested functionality on DP
• [ ] We had an implementation alignment call with stakeholders post QA Round 2
• [ ] Cypress test cases have been added and approved by SDET/manual QA
• [ ] Added Test Plan Approved label after Cypress tests were reviewed
• [ ] Added Test Plan Approved label after JUnit tests were reviewed

Summary by CodeRabbit

• Refactor
  • Improved the GitSync functionality for better user experience.
• New Features
  • Added the ability to dynamically set test identifiers for the Copy button, enhancing testing capabilities.

[brayn003]

/ok-to-test tags="@tag.Git"

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7904156251. Workflow: Appsmith External Integration Test Workflow. Tags: @tag.Git.

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7904156251. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
2. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
3. cypress/e2e/Regression/ClientSide/Git/GitSync/Merge_spec.js
4. cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js
5. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
6. cypress/e2e/Regression/ClientSide/Git/GitWithTheming/GitWithTheming_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7904156251. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
2. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
3. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
4. cypress/e2e/Regression/ClientSide/Git/GitWithTheming/GitWithTheming_spec.js

To know the list of identified flaky tests - Refer here

[coderabbitai[bot]]

Walkthrough

The modifications streamline the Git Sync functionality in the application, involving UI and testing enhancements. A locator was removed for cleanup, the GitSync class was refined with renaming and new methods for modal interactions, and a dynamic testIdSuffix was introduced for improved testability. These changes aim to enhance both the developer experience and the application's test suite reliability.

Changes

Files	Change Summary
.../cypress/locators/gitSyncLocators.js	Removed copySshKey locator
.../cypress/support/Pages/GitSync.ts	Renamed _settingsTabBranch to _gitSettingsModal; Added methods for modal and branch handling
.../src/pages/Editor/gitSync/components/CopyButton.tsx	Added testIdSuffix to CopyButtonProps and dynamic data-testid attribute

Related issues

• appsmithorg/appsmith#30378 - The changes address potential failures in the Cypress test suite by refining modal interactions and enhancing testability, aligning with the objective to fix test suite failures due to recent changes.
• appsmithorg/appsmith#29816 - The modifications to the Git modal flow and the introduction of a more dynamic testing approach could improve the Git modal's user experience and reliability, meeting the issue's objectives for enhanced clarity and usability.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7904156251. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
2. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7904156251. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7904156251. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7904156251. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts

To know the list of identified flaky tests - Refer here

[brayn003]

cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts

seems to be flaky. Re-running one last time

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7904156251. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts

To know the list of identified flaky tests - Refer here

[brayn003]

/ok-to-test tags="@tag.Git"

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Workflow: Appsmith External Integration Test Workflow. Tags: @tag.Git.

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
4. cypress/e2e/Regression/ClientSide/Git/GitSync/MergeViaRemote_spec.ts
5. cypress/e2e/Regression/ClientSide/Git/GitSync/Merge_spec.js
6. cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js
7. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
4. cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js
5. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
4. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
4. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7912015282. Commit: ``. Cypress dashboard url: Click here! All cypress tests have passed 🎉🎉🎉

[brayn003]

/ok-to-test tags="@tag.Git"

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7928373944. Workflow: Appsmith External Integration Test Workflow. Tags: @tag.Git.

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7928373944. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/BugTests/GitBugs_Spec.ts
2. cypress/e2e/Regression/ClientSide/Git/GitImport/ImportEmptyRepo_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
4. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
5. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
6. cypress/e2e/Regression/ClientSide/Git/GitSync/MergeViaRemote_spec.ts
7. cypress/e2e/Regression/ClientSide/Git/GitSync/Merge_spec.js
8. cypress/e2e/Regression/ClientSide/Git/GitWithTheming/GitWithTheming_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

[brayn003]

/ok-to-test tags="@tag.Git"

[github-actions[bot]]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8106905064. Workflow: Appsmith External Integration Test Workflow. Tags: @tag.Git.

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8106905064. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitImport/ImportEmptyRepo_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
4. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
5. cypress/e2e/Regression/ClientSide/Git/GitSync/MergeViaRemote_spec.ts
6. cypress/e2e/Regression/ClientSide/Git/GitSync/Merge_spec.js
7. cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js
8. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js
9. cypress/e2e/Regression/ClientSide/Git/GitWithTheming/GitWithTheming_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8106905064. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/DisconnectGit_spec.js
3. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
4. cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js
5. cypress/e2e/Regression/ClientSide/Git/GitWithJSLibrary/GitwithCustomJSLibrary_spec.js

To know the list of identified flaky tests - Refer here

[github-actions[bot]]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8106905064. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:

1. cypress/e2e/Regression/ClientSide/Git/GitSync/Deploy_spec.js
2. cypress/e2e/Regression/ClientSide/Git/GitSync/GitConnectV2_spec.ts
3. cypress/e2e/Regression/ClientSide/Git/GitWithAutoLayout/conversion_of_git_connected_apps_spec.js

To know the list of identified flaky tests - Refer here