appsmith
appsmith copied to clipboard
appsmithorg
fix: Anvil Bug fixes for R1
Pull Request Template
Use this template to quickly create a well written pull request. Delete all quotes before creating the pull request.
Description
This PR has multiple bug fixes
- Widget boundary showing up in preview mode.
- Widget flickering when space distribution changes.
- highlights seem blurred near table widget
- scrolling to widget when clicked from entity explorer.
PR fixes following issue(s)
Fixes # (issue number)
if no issue exists, please create an issue and ask the maintainers about this first
Media
A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video
Type of change
Please delete options that are not relevant.
- Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Chore (housekeeping or task changes that don't impact user perception)
- This change requires a documentation update
Testing
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant
- [ ] Manual
- [ ] JUnit
- [ ] Jest
- [ ] Cypress
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Speedbreak features have been covered
- [ ] Test plan covers all impacted features and areas of interest
- [ ] Test plan has been peer reviewed by project stakeholders and other QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added
Test Plan Approvedlabel after Cypress tests were reviewed - [ ] Added
Test Plan Approvedlabel after JUnit tests were reviewed
Summary by CodeRabbit
- New Features
- Introduced ease-in animation for flexgrow value changes in layout components.
- Enhanced canvas dragging experience by updating z-index based on activation state.
- Improvements
- Optimized widget rendering by utilizing unique widget IDs.
- Improved code maintainability with the introduction of a styled
canvascomponent for better styling encapsulation.
- Bug Fixes
- Fixed widget focus functionality by implementing a new widget selector based on layout system type, ensuring accurate quick scrolling to widgets.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7874597547.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31066.
recreate: .
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7885043644.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31066.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7885618919.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31066.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7886092675.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31066.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7887381683.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31066.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7901335603.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31066.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7911633456.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31066.
recreate: .
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7911635239.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Anvil.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/7911747222.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31066.
recreate: .
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7911635239. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:
- cypress/e2e/Regression/ClientSide/Anvil/AnvilAppNavigation_spec.ts
- cypress/e2e/Regression/ClientSide/Anvil/AnvilDnD_spec.ts
- cypress/e2e/Regression/ClientSide/Anvil/AnvilSuggestedWidgets_spec.ts
- cypress/e2e/Regression/ClientSide/Anvil/AnvilWidgetClicking_spec.ts
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7926834331.
Workflow: Appsmith External Integration Test Workflow.
Tags: @tag.Anvil.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7926834331. Commit: ``. Cypress dashboard: Click here! The following are new failures, please fix them before merging the PR:
- cypress/e2e/Regression/ClientSide/Anvil/AnvilAppNavigation_spec.ts
- cypress/e2e/Regression/ClientSide/Anvil/AnvilDnD_spec.ts
- cypress/e2e/Regression/ClientSide/Anvil/AnvilSuggestedWidgets_spec.ts
- cypress/e2e/Regression/ClientSide/Anvil/AnvilWidgetClicking_spec.ts