appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Task]: Move expires_in field after scope while configuring oauth2 datasource

Open sneha122 opened this issue 1 year ago • 15 comments

SubTasks

When creating authenticated API datasource for OAuth2, shift expires_in input field just after scope, so that all authentication fields are adjacent to each other, and users can discover it quickly Screenshot 2024-02-12 at 3 38 29 PM

sneha122 avatar Feb 12 '24 10:02 sneha122

If this issue has to be worked on, I can take it up

yasharma2301 avatar Feb 16 '24 04:02 yasharma2301

@sneha122 @Nikhil-Nandagopal Hi. I want to ask if this is a rendered HTML page or something else. It may sound stupid, but it's my first time contributing.

bandhan-majumder avatar Mar 08 '24 14:03 bandhan-majumder

Hi @sneha122 I'm interested to start off my contribution through this issue. I need one clarification. Is shifting expires_in field alone is okay OR all 2 following fields ( Audience & Resource ) also need to be shifted ? image

image

theAravinthM avatar Mar 09 '24 12:03 theAravinthM

Hi @yasharma2301 This is a good first issue, you can take it up if you want, Apologies for the delayed response!!

sneha122 avatar Mar 09 '24 16:03 sneha122

Hi @theAravinthM We just need to shift expires_in field after the scope, no need to shift other fields, they can remain as they are today, Hope this helps!

sneha122 avatar Mar 09 '24 16:03 sneha122

Hi @bandhan-majumder The code for this is written in JSX, which is eventually translated to HTML internally by React framework, Hope this answer helps!!

sneha122 avatar Mar 09 '24 16:03 sneha122

Hi @sneha122 ! Just made a PR - #31863 . Could you please review!

theAravinthM avatar Mar 18 '24 11:03 theAravinthM

hey @sneha122 is this issue resolved or anyone is already working on it?

subhajit20 avatar Mar 30 '24 07:03 subhajit20

@subhajit20 Yes there are already PRs created for this

sneha122 avatar Apr 01 '24 06:04 sneha122

Hello, is this issue still open?

BOSE-git avatar Jul 22 '24 06:07 BOSE-git

Hi @BOSE-git There were PRs created for this issue earlier but due to various issues, we could not get around to merging these PRs. Let us discuss this internally and prioritise.

sneha122 avatar Jul 22 '24 11:07 sneha122

Should I connect on LinkedIn?

BOSE-git avatar Jul 22 '24 11:07 BOSE-git

If there is any issue that I can help with, I will be happy to contribute

BOSE-git avatar Jul 22 '24 14:07 BOSE-git

Moving this to Product Backlog as no response from the contributor

NilanshBansal avatar Aug 09 '24 04:08 NilanshBansal