appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Bug]: Changing the selection of Border Radius/Box Shadow of Buttons in JSONForm is not visible in property pane

Open chandannkumar opened this issue 2 years ago • 20 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

On changing the box radius and box shadow of "Submit" & "Reset" button are not visible, although the changes are happening in widget according to selection in the property pane.

Steps To Reproduce

  1. Drag & Drop a JSONForm
  2. Go to Style tab
  3. Under the Submit button styles, change the Border Radius
  4. Observe that the change affects the widget but the selection in property pane is still same
  5. Try same with Reset Button styles
  6. Observe that there is no change in property pane on selecting different Border radius/Box shadow

Public Sample App

No response

Environment

Production

Issue video log

https://www.loom.com/share/9212808497cf42d08ccd502bb22b6047

Version

Cloud/Production

chandannkumar avatar Jun 12 '23 14:06 chandannkumar

@chandannkumar @dilippitchika Hi, I would like to work on this if it is available.

manishdait avatar Jun 16 '23 07:06 manishdait

@dilippitchika @chandannkumar Hi, I would like to work on this if it is available.

sadelax avatar Jun 20 '23 15:06 sadelax

Hello @ManishDait @sadelax thanks for showing interest, please feel free to pick this issue up. I am assigning this to both of you. Please don't forget to read the Contribution Guidelines. Would appreciate if one of you can open a PR within the next 2 days. let us know here

dilippitchika avatar Jun 23 '23 03:06 dilippitchika

@sadelax @ManishDait Are you still working on this? If not I want to work on this.

ghost avatar Jun 28 '23 11:06 ghost

@sadelax @ManishDait Are you still working on this? If not I want to work on this.

Yes you can

manishdait avatar Jun 28 '23 11:06 manishdait

I found that JsonForm.__evaluation__.evaluatedValues.submitButtonStyles.borderRadius and boxShadow is not updating when we try to change borderRadius and boxShadow on buttons. This issue is related to evalTree(evaluations tree). It will be helpful if @sadelax @ManishDait you are working on this.

ghost avatar Jun 28 '23 11:06 ghost

This is occurring in DataTreeEvaluator Object and related to evalTree Web Worker.

If no one is working on this @dilippitchika @chandannkumar you can assign it to me.

ghost avatar Jun 28 '23 11:06 ghost

I am working on it

ghost avatar Jun 29 '23 09:06 ghost

@chandannkumar @dilippitchika Hi, please assign this issue to me. I want to work on it.

shoaib-31 avatar Sep 30 '23 21:09 shoaib-31

Is this issue still open?

akshat8605 avatar Apr 02 '24 13:04 akshat8605

Is someone working on this ? Can I take on it ?

prajyot004 avatar May 07 '24 13:05 prajyot004

hi, if this problem is not assigned I would like to take it

moradebianchetti81 avatar May 12 '24 21:05 moradebianchetti81

hey, @chandannkumar I don't think so that there is something wrong with shadow, I did the check cross there and the shadow was working fine even by changing the CSS property. Screenshot (14)

As you can see in the SS that the shadow is visible and working fine.

Abhxhek avatar May 20 '24 08:05 Abhxhek

Is this issue still open I would love to pick this up and provide a fix ASAP

mittalsam98 avatar Jul 29 '24 09:07 mittalsam98

Is this issue open cause i would like to solve it

udayxyz avatar Aug 08 '24 13:08 udayxyz

is this issue open? can I get assigned for this?

Danesh-md avatar Oct 06 '24 02:10 Danesh-md

@Danesh-md Thanks for your interest in solving this, this is not a priority for us. Can you take a look at this list and picking anything that interests you?

rahulbarwal avatar Oct 07 '24 06:10 rahulbarwal

@chandannkumar , could you please assign this issue to me? I’d love to work on it. Thanks!

Shlokmonster avatar Feb 20 '25 07:02 Shlokmonster

@Shlokmonster This is not a priority at the moment, please take a look at this list https://github.com/appsmithorg/appsmith/labels/Inviting%20Contribution and pick up if anything interests you.

rahulbarwal avatar Feb 24 '25 06:02 rahulbarwal

@chandannkumar and @dilippitchika Hi there, I want to work on this issue, please assign this to me

absolutechy avatar Jun 12 '25 07:06 absolutechy

@chandannkumar, @dilippitchika and @vivek-appsmith Hi, there. I hope to work for this issue. Could you assign this to me(If this issue still open🤗)!

MayRhee-ANU avatar Sep 30 '25 07:09 MayRhee-ANU

Hey Can I work on this issue?

IshikaSinghRajput avatar Nov 08 '25 07:11 IshikaSinghRajput

Hi @chandannkumar, I would like to work on this issue. Could you please assign it to me? Thanks!

duvvuvenkataramana avatar Nov 22 '25 10:11 duvvuvenkataramana

APP-14628

linear[bot] avatar Nov 26 '25 07:11 linear[bot]