appsmith
appsmith copied to clipboard
[Bug]: Changing the selection of Border Radius/Box Shadow of Buttons in JSONForm is not visible in property pane
Is there an existing issue for this?
- [X] I have searched the existing issues
Description
On changing the box radius and box shadow of "Submit" & "Reset" button are not visible, although the changes are happening in widget according to selection in the property pane.
Steps To Reproduce
- Drag & Drop a JSONForm
- Go to Style tab
- Under the Submit button styles, change the Border Radius
- Observe that the change affects the widget but the selection in property pane is still same
- Try same with Reset Button styles
- Observe that there is no change in property pane on selecting different Border radius/Box shadow
Public Sample App
No response
Environment
Production
Issue video log
https://www.loom.com/share/9212808497cf42d08ccd502bb22b6047
Version
Cloud/Production
@chandannkumar @dilippitchika Hi, I would like to work on this if it is available.
@dilippitchika @chandannkumar Hi, I would like to work on this if it is available.
Hello @ManishDait @sadelax thanks for showing interest, please feel free to pick this issue up. I am assigning this to both of you. Please don't forget to read the Contribution Guidelines. Would appreciate if one of you can open a PR within the next 2 days. let us know here
@sadelax @ManishDait Are you still working on this? If not I want to work on this.
@sadelax @ManishDait Are you still working on this? If not I want to work on this.
Yes you can
I found that JsonForm.__evaluation__.evaluatedValues.submitButtonStyles.borderRadius and boxShadow is not updating when we try to change borderRadius and boxShadow on buttons. This issue is related to evalTree(evaluations tree). It will be helpful if @sadelax @ManishDait you are working on this.
This is occurring in DataTreeEvaluator Object and related to evalTree Web Worker.
If no one is working on this @dilippitchika @chandannkumar you can assign it to me.
I am working on it
@chandannkumar @dilippitchika Hi, please assign this issue to me. I want to work on it.
Is this issue still open?
Is someone working on this ? Can I take on it ?
hi, if this problem is not assigned I would like to take it
hey,
@chandannkumar
I don't think so that there is something wrong with shadow, I did the check cross there and the shadow was working fine even by changing the CSS property.
As you can see in the SS that the shadow is visible and working fine.
Is this issue still open I would love to pick this up and provide a fix ASAP
Is this issue open cause i would like to solve it
is this issue open? can I get assigned for this?
@Danesh-md Thanks for your interest in solving this, this is not a priority for us. Can you take a look at this list and picking anything that interests you?
@chandannkumar , could you please assign this issue to me? I’d love to work on it. Thanks!
@Shlokmonster This is not a priority at the moment, please take a look at this list https://github.com/appsmithorg/appsmith/labels/Inviting%20Contribution and pick up if anything interests you.
@chandannkumar and @dilippitchika Hi there, I want to work on this issue, please assign this to me
@chandannkumar, @dilippitchika and @vivek-appsmith Hi, there. I hope to work for this issue. Could you assign this to me(If this issue still open🤗)!
Hey Can I work on this issue?
Hi @chandannkumar, I would like to work on this issue. Could you please assign it to me? Thanks!