appsmith
appsmith copied to clipboard
fix: Updated error message on logo
Description
Error message on uploading Logo shows 100MB instead of 1MB
Error message included 100 MB as input number, changed it to 1 MB.
PR fixes following issue(s)
Fixes #23168
Type of change
- Bug fix (non-breaking change which fixes an issue)
Testing
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant
- [x] Manual
- [ ] Jest
- [ ] Cypress
Test Plan
Add Testsmith test cases links that relate to this PR
Issues raised during DP testing
Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
QA activity:
- [ ] Speedbreak features have been covered
- [ ] Test plan covers all impacted features and areas of interest
- [ ] Test plan has been peer reviewed by project stakeholders and other QA members
- [ ] Manually tested functionality on DP
- [ ] We had an implementation alignment call with stakeholders post QA Round 2
- [ ] Cypress test cases have been added and approved by SDET/manual QA
- [ ] Added
Test Plan Approved
label after Cypress tests were reviewed - [ ] Added
Test Plan Approved
label after JUnit tests were reviewed
Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.
/build-deploy-preview env=release
/ok-to-test
/build-deploy-preview env=release skip-tests=true
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4981324540.
Workflow: On demand build Docker image and deploy preview
.
skip-tests: true
.
env: release
.
PR: 23310.
recreate: .
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4981324895.
Workflow: Appsmith External Integration Test Workflow
.
Commit: ``.
PR: 23310.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23310&runId=4981324895_1
@harshitpandey0426 can you please back merge the release branch here once?
Deploy-Preview-URL: https://appsmith-ey6dnv22j-get-appsmith.vercel.app
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4981324895. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
@somangshu I have pulled in the latest changes
/ok-to-test
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4988200462.
Workflow: Appsmith External Integration Test Workflow
.
Commit: ``.
PR: 23310.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23310&runId=4988200462_1
tested deploy preview. LGTM
@somangshu ig I dont have the access to merge PR, only contributors can merge right?
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4988200462. Commit: ``. The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
- cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts