appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: misc ads bugs

Open akash-codemonk opened this issue 2 years ago • 3 comments

Description

https://www.notion.so/appsmith/Entity-explorer-functionality-QA-callout-bb3f7b44f544497cba6d8ce800909f38?pvs=4#2c80b9c6a17c44ef88f10cf72b44af81 The MenuContent height seems to shrink when it doesn't have much space. Resetting the max height seems to maintain the height and positions itself to be fully visible. Fixed in https://github.com/appsmithorg/appsmith/pull/23259

https://www.notion.so/appsmith/Entity-explorer-functionality-QA-callout-bb3f7b44f544497cba6d8ce800909f38?pvs=4#7113a59d1c7e481693ad9b855bcb0899 Not closing the menu programmatically makes the menu component eat up all keyboard shortcuts. Closing the menu as in setting the isOpen to false seems to get the keyboard shortcuts working again.

https://www.notion.so/appsmith/Changes-are-being-saved-when-not-intended-in-Application-page-d3c5f5bae2e84463916560d4bd7fef88 Missed workspace name in https://github.com/appsmithorg/appsmith/pull/23259 fixed it here.

https://www.notion.so/appsmith/Entity-explorer-functionality-QA-callout-bb3f7b44f544497cba6d8ce800909f38?pvs=4#d8d8e69d79b14c4ca519239de251c19a Added back tooltip

akash-codemonk avatar May 13 '23 10:05 akash-codemonk

/build-deploy-preview env=release

rohitagarwal88 avatar May 13 '23 16:05 rohitagarwal88

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4967899480. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23306. recreate: .

github-actions[bot] avatar May 13 '23 16:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-fsk8y8czq-get-appsmith.vercel.app

github-actions[bot] avatar May 13 '23 17:05 github-actions[bot]

/build-deploy-preview env=release

akash-codemonk avatar May 14 '23 04:05 akash-codemonk

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4970478384. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23306. recreate: .

github-actions[bot] avatar May 14 '23 04:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-yjr1w4wlx-get-appsmith.vercel.app

github-actions[bot] avatar May 14 '23 04:05 github-actions[bot]

/build-deploy-preview env=release

akash-codemonk avatar May 15 '23 06:05 akash-codemonk

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4977433102. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23306. recreate: .

github-actions[bot] avatar May 15 '23 06:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-3379dw03f-get-appsmith.vercel.app

github-actions[bot] avatar May 15 '23 07:05 github-actions[bot]