appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix: ds pages, api pages spacing, focus border, etc issues

Open AmanAgarwal041 opened this issue 1 year ago • 13 comments

Description

The PR fixes :

  • Datasource pages spacing issues
  • Debugger padding and gap issues
  • Input Elements focus border cut issues

Notion Links:

  • https://www.notion.so/appsmith/f353d8c6bd664f79ad858a42010cdfc8?v=f04cde23f6424aeb9d5a6e389cd172bd&p=f1d661d4edd9465aac3aea5f9a706225&pm=s
  • https://www.notion.so/appsmith/f353d8c6bd664f79ad858a42010cdfc8?v=f04cde23f6424aeb9d5a6e389cd172bd&p=e64785ef92a44bfbb18ce2b631d78c16&pm=s
  • https://www.notion.so/appsmith/f353d8c6bd664f79ad858a42010cdfc8?v=f04cde23f6424aeb9d5a6e389cd172bd&p=a3f230880f714e39951259215829d1c7&pm=s

PR fixes following issue(s)

Fixes # (issue number)

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [ ] Manual
  • [ ] Jest
  • [ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

AmanAgarwal041 avatar May 12 '23 12:05 AmanAgarwal041

@AmanAgarwal041 : Please add notion link of the fixes

rohitagarwal88 avatar May 12 '23 13:05 rohitagarwal88

/build-deploy-preview env=release

tanvibhakta avatar May 12 '23 13:05 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4959624266. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23290. recreate: .

github-actions[bot] avatar May 12 '23 13:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-lvp7j7ogl-get-appsmith.vercel.app

github-actions[bot] avatar May 12 '23 14:05 github-actions[bot]

/build-deploy-preview env=release

tanvibhakta avatar May 13 '23 02:05 tanvibhakta

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4964737350. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23290. recreate: .

github-actions[bot] avatar May 13 '23 02:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-j6j46y5nc-get-appsmith.vercel.app

github-actions[bot] avatar May 13 '23 03:05 github-actions[bot]

/build-deploy-preview env=release

AmanAgarwal041 avatar May 13 '23 12:05 AmanAgarwal041

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4966814452. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23290. recreate: .

github-actions[bot] avatar May 13 '23 12:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-7fqdcwod7-get-appsmith.vercel.app

github-actions[bot] avatar May 13 '23 12:05 github-actions[bot]

/build-deploy-preview env=release

AmanAgarwal041 avatar May 13 '23 16:05 AmanAgarwal041

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4967755735. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23290. recreate: .

github-actions[bot] avatar May 13 '23 16:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-5irpzwj3e-get-appsmith.vercel.app

github-actions[bot] avatar May 13 '23 16:05 github-actions[bot]

/build-deploy-preview env=release

AmanAgarwal041 avatar May 14 '23 10:05 AmanAgarwal041

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4971758353. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23290. recreate: .

github-actions[bot] avatar May 14 '23 10:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-dsdlfdm84-get-appsmith.vercel.app

github-actions[bot] avatar May 14 '23 10:05 github-actions[bot]