appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

chore: Disable postProc during fn determination

Open rishabhrathod01 opened this issue 2 years ago • 14 comments

Description

PR fixes following issue(s)

Fixes https://github.com/appsmithorg/appsmith/issues/22714 Fixes https://github.com/appsmithorg/appsmith/issues/22636 Fixes https://github.com/appsmithorg/appsmith/issues/22779

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [ ] Manual
  • [ ] Jest
  • [ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

rishabhrathod01 avatar May 12 '23 12:05 rishabhrathod01

/ok-to-test sha=

rishabhrathod01 avatar May 12 '23 12:05 rishabhrathod01

/ok-to-test sha=

rishabhrathod01 avatar May 12 '23 12:05 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4959048689. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23289. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23289&runId=4959048689_1

github-actions[bot] avatar May 12 '23 12:05 github-actions[bot]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4959049078. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23289. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23289&runId=4959049078_1

github-actions[bot] avatar May 12 '23 12:05 github-actions[bot]

/ok-to-test sha=42ba287

rishabhrathod01 avatar May 12 '23 12:05 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4959053637. Workflow: Appsmith External Integration Test Workflow. Commit: 42ba287. PR: 23289. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23289&runId=4959053637_1

github-actions[bot] avatar May 12 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4959053637. Commit: 42ba287. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/MongoDBShoppingCart_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/AppNavigation/TopStacked_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/IconButton_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 14:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4959049078. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/ButtonWidgets_NavigateTo_validation_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/Linting/BasicLint_spec.ts
  6. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/CurrencyInput/CurrencyInput_spec.js
  7. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/IconButton_spec.js
  8. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  9. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/Array_Spec.ts
  10. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 14:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4959048689. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 14:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4959048689. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 13 '23 07:05 github-actions[bot]

/ok-to-test sha=331da1a

rishabhrathod01 avatar May 13 '23 07:05 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4965723140. Workflow: Appsmith External Integration Test Workflow. Commit: 331da1a. PR: 23289. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23289&runId=4965723140_1

github-actions[bot] avatar May 13 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4965723140. Commit: 331da1a. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/TableV2/Inline_editing_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 13 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4965723140. Commit: 331da1a. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 13 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4965723140. Commit: 331da1a. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 14 '23 09:05 github-actions[bot]

/ok-to-test sha=8669c86

rishabhrathod01 avatar May 14 '23 09:05 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4971741727. Workflow: Appsmith External Integration Test Workflow. Commit: 8669c86. PR: 23289. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23289&runId=4971741727_1

github-actions[bot] avatar May 14 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4971741727. Commit: 8669c86. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  2. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 14 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4971741727. Commit: 8669c86. All cypress tests have passed 🎉

github-actions[bot] avatar May 14 '23 12:05 github-actions[bot]

/perf-test

rishabhrathod01 avatar May 15 '23 12:05 rishabhrathod01

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4980469611. Workflow: Performance Tests Workflow. Commit: ``. PR: 23289. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23289&runId=4980469611_1

github-actions[bot] avatar May 15 '23 12:05 github-actions[bot]