appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix: ArangoDB Integration: fix error message on bad host address and timeout

Open sumitsum opened this issue 2 years ago • 4 comments

Description

  • Add infra to re-format error messages.
  • Re-format error message for test datasource failure due to (1) bad endpoint (2) timeout

PR fixes following issue(s)

Fixes #21782

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

  • JUnit TCs
  • Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

sumitsum avatar May 12 '23 07:05 sumitsum

/ok-to-test

sumitsum avatar May 12 '23 09:05 sumitsum

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4957567098. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23267. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23267&runId=4957567098_1

github-actions[bot] avatar May 12 '23 09:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957567098. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4957567098. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 13:05 github-actions[bot]

/ok-to-test

sumitsum avatar May 15 '23 05:05 sumitsum

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4976697415. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23267. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23267&runId=4976697415_1

github-actions[bot] avatar May 15 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4976697415. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/MongoDBShoppingCart_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 15 '23 06:05 github-actions[bot]

/build-deploy-preview skip-tests=true

sumitsum avatar May 15 '23 23:05 sumitsum

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4986144636. Workflow: On demand build Docker image and deploy preview. skip-tests: true. env: ``. PR: 23267. recreate: .

github-actions[bot] avatar May 15 '23 23:05 github-actions[bot]

Deploy-Preview-URL: https://ce-23267.dp.appsmith.com

github-actions[bot] avatar May 15 '23 23:05 github-actions[bot]

/ok-to-test

sumitsum avatar May 16 '23 11:05 sumitsum

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4991080910. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23267. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23267&runId=4991080910_1

github-actions[bot] avatar May 16 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4991080910. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/CreateNewApp_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 16 '23 13:05 github-actions[bot]

/ok-to-test

sumitsum avatar May 17 '23 01:05 sumitsum

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4998450779. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23267. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23267&runId=4998450779_1

github-actions[bot] avatar May 17 '23 01:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4998450779. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/MongoDBShoppingCart_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/AdminSettings/Admin_settings_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  4. cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  7. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 17 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4998450779. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 17 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4998450779. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 17 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4998450779. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitSyncedApps_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 17 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4998450779. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 17 '23 09:05 github-actions[bot]

/ok-to-test

sumitsum avatar May 22 '23 05:05 sumitsum

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5042210804. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23267. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23267&runId=5042210804_1

github-actions[bot] avatar May 22 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5042210804. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ServerSide/JsFunctionExecution/JSFunctionExecution_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 22 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5042210804. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/JSFunctionExecution_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 22 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5042210804. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 22 '23 08:05 github-actions[bot]