appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

Published 20 hours ago • verified publisher icon appsmithorg

fix code to UI breaking by disabling JS toggle

Open ravikp7 opened this issue 1 year ago • 3 comments

Description

In some cases, while converting code to UI, the actions were being rendered incorrectly. This PR addresses the issue by disabling the JS toggle in such cases.

PR fixes following issue(s)

Fixes #22180 #22505

Media

Screenshot 2023-05-12 at 12 02 04 AM Screenshot 2023-05-12 at 12 02 11 AM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration. Delete anything that is not relevant

  • [ ] Manual
  • [ ] Jest
  • [x] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

ravikp7 avatar May 11 '23 18:05 ravikp7

/ok-to-test sha=70e8d30

ravikp7 avatar May 11 '23 18:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4951389426. Workflow: Appsmith External Integration Test Workflow. Commit: 70e8d30. PR: 23242. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23242&runId=4951389426_1

github-actions[bot] avatar May 11 '23 18:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4951389426. Commit: 70e8d30. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/MongoDBShoppingCart_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/uiToCode/uiToCode_spec.ts
  4. cypress/integration/Regression_TestSuite/ClientSideTests/AdminSettings/Admin_settings_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  6. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  7. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Admin_settings_spec.js
  8. cypress/integration/Regression_TestSuite/ClientSideTests/ExplorerTests/Scrolling_Spec.ts
  9. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  10. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Button/Button_spec.js
  11. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Chart/Chart_Widget_Loading_spec.js
  12. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/ListV2_PageNo_PageSize_spec.js
  13. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_BasicServerSideData_spec.js
  14. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres1_Spec.ts
  15. cypress/integration/Regression_TestSuite/ServerSideTests/MySQL_Datatypes/False_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 20:05 github-actions[bot]

/ok-to-test sha=1b4b99a

ravikp7 avatar May 16 '23 10:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4990944909. Workflow: Appsmith External Integration Test Workflow. Commit: 1b4b99a. PR: 23242. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23242&runId=4990944909_1

github-actions[bot] avatar May 16 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4990944909. Commit: 1b4b99a. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/uiToCode/uiToCode_spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/AllWidgets_Reset_Spec.ts
  4. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  5. cypress/integration/Regression_TestSuite/ClientSideTests/EmbedSettings/EmbedSettings_spec.js
  6. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
  9. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 16 '23 12:05 github-actions[bot]

/ok-to-test sha=4af6285

ravikp7 avatar May 17 '23 05:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4999584616. Workflow: Appsmith External Integration Test Workflow. Commit: 4af6285. PR: 23242. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23242&runId=4999584616_1

github-actions[bot] avatar May 17 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4999584616. Commit: 4af6285. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/uiToCode/uiToCode_spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  6. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  7. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/IconButton_spec.js
  8. cypress/integration/Regression_TestSuite/ClientSideTests/Workspace/ShareAppTests_spec.js
  9. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  10. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 17 '23 06:05 github-actions[bot]

/ok-to-test sha=efad61e

ravikp7 avatar May 17 '23 10:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5002392403. Workflow: Appsmith External Integration Test Workflow. Commit: efad61e. PR: 23242. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23242&runId=5002392403_1

github-actions[bot] avatar May 17 '23 10:05 github-actions[bot]

/ok-to-test sha=1636a1e

ravikp7 avatar May 17 '23 11:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5002659707. Workflow: Appsmith External Integration Test Workflow. Commit: 1636a1e. PR: 23242. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23242&runId=5002659707_1

github-actions[bot] avatar May 17 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5002392403. Commit: efad61e. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/ActionSelector_JsToNonJSMode_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/ActionExecution/uiToCode/uiToCode_spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug19982_Spec.ts
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 17 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5002659707. Commit: 1636a1e. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/PeekOverlay/PeekOverlay_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 17 '23 13:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5002659707. Commit: 1636a1e. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 17 '23 15:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5002659707. Commit: 1636a1e. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 18 '23 02:05 github-actions[bot]

/build-deploy-preview env=release

ravikp7 avatar May 18 '23 10:05 ravikp7

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5013108931. Workflow: On demand build Docker image and deploy preview. skip-tests: ``. env: release. PR: 23242. recreate: .

github-actions[bot] avatar May 18 '23 10:05 github-actions[bot]

Deploy-Preview-URL: https://appsmith-2giecerue-get-appsmith.vercel.app

github-actions[bot] avatar May 18 '23 11:05 github-actions[bot]

lgtm cc: @ravikp7

ramsaptami avatar May 18 '23 14:05 ramsaptami

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5002659707. Commit: 1636a1e. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 18 '23 18:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5002659707. Commit: 1636a1e. All cypress tests have passed 🎉

github-actions[bot] avatar May 18 '23 20:05 github-actions[bot]

/ok-to-test sha=859fbb7

ravikp7 avatar May 19 '23 07:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5022074969. Workflow: Appsmith External Integration Test Workflow. Commit: 859fbb7. PR: 23242. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23242&runId=5022074969_1

github-actions[bot] avatar May 19 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5022074969. Commit: 859fbb7. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Binding/TableV2_Property_ToggleJs_With_Binding_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_Existing_app_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL1_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 19 '23 09:05 github-actions[bot]

/ok-to-test sha=7ee3ff5

ravikp7 avatar May 22 '23 07:05 ravikp7

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5043036928. Workflow: Appsmith External Integration Test Workflow. Commit: 7ee3ff5. PR: 23242. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23242&runId=5043036928_1

github-actions[bot] avatar May 22 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5043036928. Commit: 7ee3ff5. The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/DynamicHeight/Text_Widget_spec.js
  2. cypress/e2e/Regression/ServerSide/ApiTests/API_CurlPOSTImport_spec.js
  3. cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js
  4. cypress/e2e/Regression/ServerSide/QueryPane/S3_2_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 22 '23 08:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5043036928. Commit: 7ee3ff5. All cypress tests have passed 🎉

github-actions[bot] avatar May 22 '23 09:05 github-actions[bot]