appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix: ensure the code doesn’t crash in the worker environment

Open iamakulov opened this issue 2 years ago • 3 comments

Description

This PR ensures getAppsmithConfigs executes both in the main thread – and the worker environments. It’s a quick hotfix; the proper solution would’ve included making variables like intercomAppID optional since APPSMITH_FEATURE_CONFIGS are not always defined. This is needed for EE (in EE, the Tern worker indirectly imports and calls getAppsmithConfigs).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

  • [ ] Manual - ensured no console errors are thrown in EE anymore
  • [ ] Jest
  • [ ] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

iamakulov avatar May 11 '23 15:05 iamakulov

/ok-to-test

SatishGandham avatar May 11 '23 15:05 SatishGandham

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4949934609. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23238. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23238&runId=4949934609_1

github-actions[bot] avatar May 11 '23 15:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4949934609. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  4. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 17:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4949934609. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 03:05 github-actions[bot]

/ok-to-test

SatishGandham avatar May 12 '23 05:05 SatishGandham

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4955550897. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23238. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23238&runId=4955550897_1

github-actions[bot] avatar May 12 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4949934609. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4955550897. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_sql_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  4. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
  6. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EntityBottomBar_spec.ts
  7. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  8. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  9. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
  10. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  11. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Postgres2_Spec.ts
  12. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4949934609. Commit: ``. All cypress tests have passed 🎉

github-actions[bot] avatar May 12 '23 07:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4955550897. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_sql_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EntityBottomBar_spec.ts
  6. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  7. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 07:05 github-actions[bot]