appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

chore: Removes duplicate option from application card in workspaces page.

Open rahulbarwal opened this issue 2 years ago • 15 comments

Description

We have Fork and Duplicate options which essentially do the same thing, the former one provides us more flexibility, hence we are removing the Duplicate option completely from our app.

PR fixes following issue(s)

Fixes # (issue number) #13169

Media

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing

How Has This Been Tested?

  • [x] Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

rahulbarwal avatar May 11 '23 11:05 rahulbarwal

/ok-to-test

rahulbarwal avatar May 11 '23 11:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4947244507. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23225. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23225&runId=4947244507_1

github-actions[bot] avatar May 11 '23 11:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 11 '23 12:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4948248393. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23225. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23225&runId=4948248393_1

github-actions[bot] avatar May 11 '23 12:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 12 '23 05:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4955410746. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23225. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23225&runId=4955410746_1

github-actions[bot] avatar May 12 '23 05:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4955410746. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EntityBottomBar_spec.ts
  6. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
  7. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
  8. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/Others/IconButton_spec.js
  9. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
  10. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 06:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4955410746. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Onboarding/GuidedTour_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/EntityBottomBar_spec.ts
  5. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
  6. cypress/integration/Regression_TestSuite/ClientSideTests/Widgets/ListV2/Listv2_dataIdentifierProperty_spec.js
  7. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 10:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 12 '23 11:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4958358504. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23225. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23225&runId=4958358504_1

github-actions[bot] avatar May 12 '23 11:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4958358504. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitImport/GitImport_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Basic_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/ApiTests/API_CurlPOSTImport_spec.js
  7. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  8. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
  9. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
  10. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 12 '23 13:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4958358504. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/S3_1_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 13 '23 10:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 13 '23 10:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4966487900. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23225. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23225&runId=4966487900_1

github-actions[bot] avatar May 13 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4966487900. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug9334_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/IDE/Command_Click_Navigation_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 13 '23 12:05 github-actions[bot]

/ok-to-test

rahulbarwal avatar May 16 '23 04:05 rahulbarwal

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4987848105. Workflow: Appsmith External Integration Test Workflow. Commit: ``. PR: 23225. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23225&runId=4987848105_1

github-actions[bot] avatar May 16 '23 04:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4987848105. Commit: ``. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/MongoDBShoppingCart_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  3. cypress/integration/Regression_TestSuite/ClientSideTests/VisualTests/JSEditorIndent_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/JSOnLoad2_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 16 '23 05:05 github-actions[bot]