appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard

[Bug]: Sort/Freeze controls still exist in the Table header after sorting and freezing have both been disabled.

Open AS-Laguna opened this issue 1 year ago • 1 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Description

The sort/freeze controls still exist in the DOM if sorting and freezing are disabled for a column. This causes unnecessary squeeze on the column headers.

I expect the DOM element to disappear and give way to the header text if both behaviors are disabled.

Here is an example of this squeeze. If the user makes one of the columns any smaller, the header text is truncated.

image

Steps To Reproduce

  1. D&D a table onto the canvas.
  2. Disable sorting and freezing for the table.
  3. Observe that the dropdown arrow still exists in the header.
  4. Reduce the width of one of the columns.
  5. Observe that this control takes up space and causes premature truncation of the header text.

Public Sample App

No response

Environment

Production

Issue video log

No response

Version

Cloud v1.9.18-SNAPSHOT

Front logo Front conversations

AS-Laguna avatar May 10 '23 21:05 AS-Laguna

This will help the mobile App I'm developing immensely with Real Estate. Thanks!

pchambless avatar May 11 '23 14:05 pchambless

@somangshu @dilippitchika Can I work on this issue?

Sheikh-JamirAlam avatar May 28 '23 08:05 Sheikh-JamirAlam

@Sheikh-JamirAlam yes sure, assigning this to you. Feel free to raise a PR in the next few days.

dilippitchika avatar May 29 '23 06:05 dilippitchika

@AS-Laguna @dilippitchika Should I raise a PR?

Screencast from 02-06-23 11:59:25 AM IST.webm

Sheikh-JamirAlam avatar Jun 02 '23 06:06 Sheikh-JamirAlam

@AS-Laguna @dilippitchika Should I raise a PR?

Yes, please 😄

ghost avatar Jun 02 '23 14:06 ghost

Please review the PR @AS-Laguna @dilippitchika

Sheikh-JamirAlam avatar Jun 02 '23 18:06 Sheikh-JamirAlam