appsmith
appsmith copied to clipboard
appsmithorg
fix: Add support for xls,json,tsv file types in file widget
Fixes #17946
This PR adds support for parsing XLS,XLSX, TSV, JSON and CSV files in file widget v2.
Type of change
- New feature (non-breaking change which adds functionality)
- This change requires a documentation update
Testing
How Has This Been Tested?
- [x] Manual
- [x] Cypress
Test Plan
Import following file types to test if the feature works fine.
- Import xls, xlsx, json, tsv, csv file.
- Import a large file > 1 MB, > 5 MB to test the feature.
- Import file types of text,binary and base64 to test existing functionality since the whole importing code has been refactored.
Checklist:
Dev activity
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] New and existing unit tests pass locally with my changes
- [ ] PR is being merged under a feature flag
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4933543421.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2fdb155.
PR: 23159.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23159&runId=4933543421_1
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4933546121.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 23159.
recreate: .
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/4933874630.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 23159.
recreate: .
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4933874899.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0587e0a.
PR: 23159.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23159&runId=4933874899_1
Deploy-Preview-URL: https://appsmith-4l666txtc-get-appsmith.vercel.app
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4933874899.
Commit: 0587e0a.
The following are new failures, please fix them before merging the PR:
- cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5067734876.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 23159.
recreate: .
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5067734719.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9a053be.
PR: 23159.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23159&runId=5067734719_1
Deploy-Preview-URL: https://appsmith-orzgoo6ky-get-appsmith.vercel.app
@somangshu @dilippitchika does this feature need to go part of What's new updates ?
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5067734719.
Commit: 9a053be.
The following are new failures, please fix them before merging the PR:
- cypress/e2e/Regression/ClientSide/Templates/Fork_Template_Existing_app_spec.js
- cypress/e2e/Sanity/Datasources/Airtable_Basic_Spec.ts
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5075561131.
Workflow: Appsmith External Integration Test Workflow.
Commit: 79deda2.
PR: 23159.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23159&runId=5075561131_1
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5075562016.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 23159.
recreate: .
@sbalaji1192 I have fixed the review feedback. You can review the changes. Thanks!
Deploy-Preview-URL: https://appsmith-2axb1jgg5-get-appsmith.vercel.app
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/5075561131.
Commit: 79deda2.
The following are new failures, please fix them before merging the PR:
- cypress/e2e/Regression/ClientSide/Templates/Fork_Template_spec.js
- cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
- cypress/e2e/Sanity/Datasources/Airtable_Basic_Spec.ts
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/5096781307.
Workflow: On demand build Docker image and deploy preview.
skip-tests: ``.
env: release.
PR: 23159.
recreate: .
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/5096781390.
Workflow: Appsmith External Integration Test Workflow.
Commit: 80f6f7c.
PR: 23159.
Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23159&runId=5096781390_1