appsmith icon indicating copy to clipboard operation
appsmith copied to clipboard
verified publisher icon appsmithorg

fix: send empty license key to intercom for CE

Open ankitsrivas14 opened this issue 2 years ago • 15 comments

Sending licence key to intercom after consent is given. For CE users, sending license key as empty string. The consent popup is not required for cloud hosting users.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

How Has This Been Tested?

  • [ ] Manual

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [ ] PR is being merged under a feature flag

QA activity:

  • [ ] Speedbreak features have been covered
  • [ ] Test plan covers all impacted features and areas of interest
  • [ ] Test plan has been peer reviewed by project stakeholders and other QA members
  • [ ] Manually tested functionality on DP
  • [ ] We had an implementation alignment call with stakeholders post QA Round 2
  • [ ] Cypress test cases have been added and approved by SDET/manual QA
  • [ ] Added Test Plan Approved label after Cypress tests were reviewed
  • [ ] Added Test Plan Approved label after JUnit tests were reviewed

ankitsrivas14 avatar May 09 '23 16:05 ankitsrivas14

/ok-to-test sha=40af9ef

ankitsrivas14 avatar May 09 '23 16:05 ankitsrivas14

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4928188659. Workflow: Appsmith External Integration Test Workflow. Commit: 40af9ef. PR: 23149. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23149&runId=4928188659_1

github-actions[bot] avatar May 09 '23 16:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4928188659. Commit: 40af9ef. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/Autocomplete/Autocomplete_JS_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 09 '23 18:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4928188659. Commit: 40af9ef. All cypress tests have passed 🎉

github-actions[bot] avatar May 09 '23 19:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4928188659. Commit: 40af9ef. All cypress tests have passed 🎉

github-actions[bot] avatar May 10 '23 04:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4928188659. Commit: 40af9ef. All cypress tests have passed 🎉

github-actions[bot] avatar May 10 '23 04:05 github-actions[bot]

/ok-to-test sha=e550cd4

ankitsrivas14 avatar May 11 '23 08:05 ankitsrivas14

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4945710707. Workflow: Appsmith External Integration Test Workflow. Commit: e550cd4. PR: 23149. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23149&runId=4945710707_1

github-actions[bot] avatar May 11 '23 08:05 github-actions[bot]

Please update the description for the cloudhosting change @ankitsrivas14

dipyamanbiswas07 avatar May 11 '23 08:05 dipyamanbiswas07

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4945710707. Commit: e550cd4. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Bug22281_WelcomeTour_spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  4. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/Mongo_Spec.ts
  5. cypress/integration/Regression_TestSuite/ServerSideTests/OnLoadTests/PostgresConnections_spec.ts
  6. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/QueryPane/Mongo_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 10:05 github-actions[bot]

/ok-to-test sha=68f197f

ankitsrivas14 avatar May 11 '23 10:05 ankitsrivas14

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4946924567. Workflow: Appsmith External Integration Test Workflow. Commit: 68f197f. PR: 23149. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23149&runId=4946924567_1

github-actions[bot] avatar May 11 '23 10:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4946924567. Commit: 68f197f. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/Application/EchoApiCMS_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  3. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  4. cypress/integration/Regression_TestSuite/ClientSideTests/Templates/Fork_Template_spec.js
  5. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Basic_spec.js
  6. cypress/integration/Regression_TestSuite/ServerSideTests/GenerateCRUD/MySQL2_Spec.ts
  7. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4946924567. Commit: 68f197f. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/BugTests/Moment_Spec.ts
  2. cypress/integration/Regression_TestSuite/ClientSideTests/Git/GitSync/GitBugs_spec.js
  3. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 12:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4946924567. Commit: 68f197f. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ServerSideTests/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 13:05 github-actions[bot]

/ok-to-test sha=8c8cc32

ankitsrivas14 avatar May 11 '23 18:05 ankitsrivas14

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/4951510780. Workflow: Appsmith External Integration Test Workflow. Commit: 8c8cc32. PR: 23149. Perf tests will be available at https://app.appsmith.com/app/performance-infra-dashboard/pr-details-638dd7cd2913ba43778b915e?pr=23149&runId=4951510780_1

github-actions[bot] avatar May 11 '23 18:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4951510780. Commit: 8c8cc32. The following are new failures, please fix them before merging the PR:

  1. cypress/integration/Regression_TestSuite/ClientSideTests/OtherUIFeatures/Omnibar_spec.js
  2. cypress/integration/Regression_TestSuite/ClientSideTests/ThemingTests/Basic_spec.js
To know the list of identified flaky tests - Refer here

github-actions[bot] avatar May 11 '23 20:05 github-actions[bot]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/4951510780. Commit: 8c8cc32. All cypress tests have passed 🎉

github-actions[bot] avatar May 11 '23 21:05 github-actions[bot]